Skip to content

gh-131507: Add a way to recreate the Misc/mypy symlinks if missing #132274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 8, 2025

Conversation

ambv
Copy link
Contributor

@ambv ambv commented Apr 8, 2025

They will be removed in source tarballs so they don't appear in the SBOM.

This is an alternative to #132270 that keeps the symlinks in the repository. This has the following advantages:

  • the list of the modules isn't stored in a .gitignore file;
  • any mypy.ini configuration files that add the Misc/mypy directory can be used in a local type-checking workflow without running any additional tools.

This allows running type checking without building Python first or running the additional script manually. This is important because the type-checking errors emitted due to missing symlinks are confusing and don't suggest what the solution is.

The only disadvantage of this PR compared to #132270 is that we still keep symlinks in the repository 🤷🏻‍♂️

They will be removed in source tarballs so they don't appear
in the SBOM.
@ambv ambv force-pushed the keep-symlinks-in-repo branch from e82534d to 987b04a Compare April 8, 2025 17:31
@ambv
Copy link
Contributor Author

ambv commented Apr 8, 2025

(I undid the mistaken force-push, but there's no log entry about that happening.)

@ambv ambv merged commit 16dcb57 into python:main Apr 8, 2025
94 checks passed
@miss-islington-app
Copy link

Thanks @ambv for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 8, 2025
…ssing (pythonGH-132274)

They will be removed in source tarballs so they don't appear
in the SBOM.
(cherry picked from commit 16dcb57)

Co-authored-by: Łukasz Langa <[email protected]>
Co-authored-by: Stan Ulbrych <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Apr 8, 2025

GH-132293 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Apr 8, 2025
ambv added a commit that referenced this pull request Apr 8, 2025
…issing (GH-132274) (#132293)

They will be removed in source tarballs so they don't appear in the SBOM.

(cherry picked from commit 16dcb57)

Co-authored-by: Łukasz Langa <[email protected]>
Co-authored-by: Stan Ulbrych <[email protected]>
seehwan pushed a commit to seehwan/cpython that referenced this pull request Apr 16, 2025
…ssing (python#132274)

They will be removed in source tarballs so they don't appear
in the SBOM.

Co-authored-by: Stan Ulbrych <[email protected]>
@ambv ambv deleted the keep-symlinks-in-repo branch May 5, 2025 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants