gh-134568: added handler for BrokenPipeError to logging.StreamHandler.emit #134569
+5
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
picnixz
reviewed
May 23, 2025
| @@ -1155,6 +1155,10 @@ def emit(self, record): | |||
| self.flush() | |||
| except RecursionError: # See issue 36272 | |||
| raise | |||
| except BrokenPipeError: | |||
There was a problem hiding this comment.
You can add a "See issue XXXX" as above for the RecursionError maybe. However, shouldn't we give the possibility to handle the error? maybe BrokenPipeError is coming from somewhere else? Here, you're redirecting sys.stdout but what if it's because of self.stream? (I don't know which is why I ask)
| except BrokenPipeError: | ||
| devnull = os.open(os.devnull, os.O_WRONLY) | ||
| os.dup2(devnull, sys.stdout.fileno()) | ||
| sys.exit(1) |
There was a problem hiding this comment.
Huh, why are we exiting the process?
| @@ -1155,6 +1155,10 @@ def emit(self, record): | |||
| self.flush() | |||
| except RecursionError: # See issue 36272 | |||
| raise | |||
| except BrokenPipeError: | |||
| devnull = os.open(os.devnull, os.O_WRONLY) | |||
| os.dup2(devnull, sys.stdout.fileno()) | |||
There was a problem hiding this comment.
Won't this have weird side-effects? Any future stdout writes won't show up.
|
See also my comments on the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.