gh-134632: Fix build-details.json to use INCLUDEPY path
#134633
+12
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix ``build-details.json`` generation to use ``INCLUDEPY``, in order to reference the ``pythonX.Y`` subdirectory of the include directory, as required in :pep:`739`, instead of the top-level include directory.
|
CC @FFY00 |
ZeroIntensity
added
build
emmatyping
approved these changes
May 26, 2025
AA-Turner
reviewed
May 26, 2025
Comment on lines
+2
to
+3
| reference the ``pythonX.Y`` subdirectory of the include directory, as | ||
| required in :pep:`739`, instead of the top-level include directory. |
There was a problem hiding this comment.
If required by the PEP, we should have a test enforcing this contract?
There was a problem hiding this comment.
Do you have anything specific in mind? Checking that the value in the generated build-details.json ends with pythonX.Y specifically, or something deeper?
There was a problem hiding this comment.
I've added a test that checks that the values of c_api.include and c_api.pkgconfig_path (if present) point to valid directories with necessary files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
build-details.jsongeneration to useINCLUDEPY, in order to reference thepythonX.Ysubdirectory of the include directory, as required in PEP-0739, instead of the top-level include directory.build-details.json:c_api.headersdoes not include thepythonX.Ydirectory #134632