Skip to content

gh-134923: Use /GENPROFILE and /USEPROFILE for Windows PGO builds #134924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 30, 2025
Merged

gh-134923: Use /GENPROFILE and /USEPROFILE for Windows PGO builds #134924

merged 1 commit into from
May 30, 2025

Conversation

zooba
Copy link
Member

@zooba zooba commented May 30, 2025 •
edited by bedevere-app bot
Loading

@zooba zooba requested a review from a team as a code owner May 30, 2025 10:03
@bedevere-app bedevere-app bot mentioned this pull request May 30, 2025
Closed
@zooba zooba added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes and removed awaiting core review labels May 30, 2025
@zooba
Copy link
Member Author

zooba commented May 30, 2025

There's a test release running at https://dev.azure.com/Python/cpython/_build/results?buildId=162238&view=results, as CI doesn't enable PGO.

@zooba
Copy link
Member Author

zooba commented May 30, 2025

Test release was good, so I think this is good to go.

@mdboom FYI, in case this might affect your benchmarking.

@mdboom
Copy link
Contributor

mdboom commented May 30, 2025

I'll kick off a benchmarking run of this PR right now to confirm no negative impact.

@mdboom
Copy link
Contributor

mdboom commented May 30, 2025

I'll kick off a benchmarking run of this PR right now to confirm no negative impact.

The results are here. Less than 0.01% slower overall, so "within the noise".

@zooba
Copy link
Member Author

zooba commented May 30, 2025

Good to know, thanks! From the docs it sounds like if anything, the time it takes to collect the profile is improved, but we don't really care too much about that anyway.

@zooba zooba merged commit 8865b4f into python:main May 30, 2025
49 checks passed
@miss-islington-app
Copy link

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

@zooba zooba deleted the gh-134923 branch May 30, 2025 18:37
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 30, 2025
@zooba @miss-islington
pythongh-134923: Use /GENPROFILE and /USEPROFILE for Windows PGO buil…
daa84bc 
…ds (pythonGH-134924)

(cherry picked from commit 8865b4f)

Co-authored-by: Steve Dower <[email protected]>
@miss-islington-app
Copy link

Sorry, @zooba, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 8865b4f95b32097099d252111669b88ec7c1eb7f 3.13

@bedevere-app
Copy link

bedevere-app bot commented May 30, 2025

GH-134950 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label May 30, 2025
@bedevere-app
Copy link

bedevere-app bot commented May 30, 2025

GH-134951 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label May 30, 2025
zooba added a commit that referenced this pull request May 30, 2025
@zooba
gh-134923: Use /GENPROFILE and /USEPROFILE for Windows PGO builds (GH…
5fd62be 
…-134924)
zooba added a commit that referenced this pull request May 30, 2025
@miss-islington @zooba
gh-134923: Use /GENPROFILE and /USEPROFILE for Windows PGO builds (GH…
32574d4 
…-134924)

(cherry picked from commit 8865b4f)

Co-authored-by: Steve Dower <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdboom mdboom mdboom approved these changes

Assignees

@zooba zooba

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zooba @mdboom