Skip to content

gh-95235: Document undocumented parameters in sqlite3 functions and methods #95236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 25, 2022

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Jul 25, 2022

@erlend-aasland erlend-aasland added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Jul 25, 2022
Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; just a couple minor comments/suggestions, thanks.

Erlend Egeberg Aasland and others added 3 commits July 25, 2022 17:23
Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @erlend-aasland !

@erlend-aasland
Copy link
Contributor Author

Thanks for the review, CAM!

@erlend-aasland erlend-aasland merged commit ac6a94c into python:main Jul 25, 2022
@miss-islington
Copy link
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@erlend-aasland erlend-aasland deleted the sqlite-doc-params branch July 25, 2022 16:46
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jul 25, 2022
@bedevere-bot
Copy link

GH-95249 is a backport of this pull request to the 3.11 branch.

@bedevere-bot
Copy link

GH-95250 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jul 25, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 25, 2022
… and methods (pythonGH-95236)

Co-authored-by: CAM Gerlach <[email protected]>
(cherry picked from commit ac6a94c)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 25, 2022
… and methods (pythonGH-95236)

Co-authored-by: CAM Gerlach <[email protected]>
(cherry picked from commit ac6a94c)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
miss-islington added a commit that referenced this pull request Jul 25, 2022
…ethods (GH-95236)

Co-authored-by: CAM Gerlach <[email protected]>
(cherry picked from commit ac6a94c)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
miss-islington added a commit that referenced this pull request Jul 25, 2022
…ethods (GH-95236)

Co-authored-by: CAM Gerlach <[email protected]>
(cherry picked from commit ac6a94c)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants