Skip to content

feat: Translate library/urllib.request.po part1 #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 8, 2021

Conversation

jordanSu
Copy link
Contributor

這篇篇幅比較長
先翻譯大約20%左右 再請大家幫忙 review 一下🙏

@mattwang44
Copy link
Collaborator

Hi @jordanSu,

有發現一個問題要麻煩你修正:如 README 中所提到的,如果有需要同時附上翻譯與原文的地方(e.g. 翻譯不常用或不確定、原文較好被理解),只需要在第一次出現的地方附上就好。例如,在 library/urllib.request.rst:15 翻譯中放了 module(模組) ,那之後出現 module 的話翻譯內容中直接放原文 module 就好;同樣的(以 module 這個詞為例),如果是希望此篇文章中要放翻譯過後的詞,要在第一次出現這個詞的地方翻作 模組 (module)、之後出現這個詞就直接翻作 模組 而不用再附上原文。目前有需要修正的詞有 module, header, class, path component, dictionary, mapping

Copy link
Collaborator

@mattwang44 mattwang44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

以下為標點符號使用及字詞翻譯相關建議,目前提到的地方都修正後,我會針對語句暢通性再 review 一次~
(btw 如果因為這篇太長而翻譯得太厭倦的話,可以像我在 #159 中一樣把一份檔案按照章節打散,issue 中註記一下進度就好)

@jordanSu
Copy link
Contributor Author

@mattwang44 感謝!
那我先把上面提到的部分改完一版再 commit 上來

@jordanSu jordanSu force-pushed the library-urllib-request branch from 03b0909 to ed1aad5 Compare December 5, 2021 15:17
@jordanSu jordanSu requested a review from mattwang44 December 6, 2021 14:06
Copy link
Collaborator

@mattwang44 mattwang44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jordanSu 語意大多通順,只剩一些小問題,這邊修掉就可以 merge 了!
(小建議:review 過後的修正就寫進新的 commit,reviewer 比較能夠快速地看出上次 review 過後改了哪些東西~)

@jordanSu jordanSu mentioned this pull request Dec 8, 2021
16 tasks
@jordanSu
Copy link
Contributor Author

jordanSu commented Dec 8, 2021

@mattwang44 感謝幫忙 review 跟 debug
我再推了一版上來了,再請幫忙 review,感謝!

@jordanSu jordanSu requested a review from mattwang44 December 8, 2021 16:07
Copy link
Collaborator

@mattwang44 mattwang44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Translating this chapter isn't easy but you've done nice work here!

@mattwang44 mattwang44 merged commit 62eaca6 into python:3.10 Dec 8, 2021
beccalzh pushed a commit to beccalzh/python-docs-zh-tw that referenced this pull request Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants