-
-
Notifications
You must be signed in to change notification settings - Fork 214
feat: Translate library/urllib.request.po part1 #162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @jordanSu, 有發現一個問題要麻煩你修正:如 README 中所提到的,如果有需要同時附上翻譯與原文的地方(e.g. 翻譯不常用或不確定、原文較好被理解),只需要在第一次出現的地方附上就好。例如,在 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
以下為標點符號使用及字詞翻譯相關建議,目前提到的地方都修正後,我會針對語句暢通性再 review 一次~
(btw 如果因為這篇太長而翻譯得太厭倦的話,可以像我在 #159 中一樣把一份檔案按照章節打散,issue 中註記一下進度就好)
@mattwang44 感謝! |
03b0909
to
ed1aad5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jordanSu 語意大多通順,只剩一些小問題,這邊修掉就可以 merge 了!
(小建議:review 過後的修正就寫進新的 commit,reviewer 比較能夠快速地看出上次 review 過後改了哪些東西~)
@mattwang44 感謝幫忙 review 跟 debug |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Translating this chapter isn't easy but you've done nice work here!
這篇篇幅比較長
先翻譯大約20%左右 再請大家幫忙 review 一下🙏