Skip to content

Gui/fix double caret #2740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 24, 2025
Merged

Gui/fix double caret #2740

merged 3 commits into from
Jun 24, 2025

Conversation

eruvanos
Copy link
Member

fixes: #2725

Basically a workaround.
UIManager holds the info about which widget is active and ensures a single active widget.
So widgets can grab the active state when they consume mouse press or release events.

All in all the naming is bad and the system introduces a whole new global state, which is bad.
In addition the name active is not intuitive, focused would be more common, but we already have experimental UIFocusGroup, which handle completely different requirements.

Guess I have to iterate on this again. But for now we needed some sort of fix

@eruvanos eruvanos merged commit 2fbb0f1 into development Jun 24, 2025
7 checks passed
@eruvanos eruvanos deleted the gui/fix-double-caret branch June 24, 2025 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Caret not deactivating on its own
1 participant