-
Notifications
You must be signed in to change notification settings - Fork 227
Add manywheel2014-builder images #785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
manywheel/build_docker.sh
Outdated
"${TOPDIR}" | ||
) | ||
IMAGES='' | ||
for DOCKER_NAME in manylinux manylinux2014; do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think if we're going to do this it should just be an env variable that you pass through instead of iterating a for
loop here, something like:
MANYLINUX_VERSION=2014 manywheel/build_docker.sh
Just so that we don't have to build all of the variants every single time.
This logic to build all of the variants can be added to manywheel/build_all_docker.sh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adopted
A maintainer needs to approve the CI run |
ping @seemethere |
I updated the BASE_CUDA_VERSION to 10.2. Should the update of cuda 10.1 to 10.2 also be done in the other places it appears:
|
@malfet @seemethere any thing else needed? |
Not after long you will need to move to manylinux2 because the latest CUDA release requires libstdc++ from GCC 5.x but the one you got in manylinux2014 is based on GCC 4.x. "CUDA Math Libraries toolchain uses C++11 features, and a C++11-compatible standard library (libstdc++ >= 20150422) is required on the host." from: https://docs.nvidia.com/cuda/cuda-toolkit-release-notes/index.html |
ENV LD_LIBRARY_PATH=/opt/rh/devtoolset-7/root/usr/lib64:/opt/rh/devtoolset-7/root/usr/lib:$LD_LIBRARY_PATH | ||
|
||
# cmake | ||
RUN yum install -y cmake3 && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As you are using manylinux2014_x86_64 as the base, it should already have cmake and gcc. So do you need to install it again?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it is already installed, yum will not install it again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
manylinux installs cmake from pypi. yum doesn't know that.
And, they don't have gcc7, they installed gcc 9. So when you install GCC7, you will get two GCCs.
... which apparently also will not be enough, see the discussion in issue #520. But this will be a first step in that direction. |
Any ideas what happened to github actions? |
@seemethere @malfet could you start CI? |
It crashed again. I rebased off master maybe that will solve it. |
This PR
If this looks OK and actually uploads some images, I think the next iterative steps would be a PR to use the images (tagged with
manylinux2014-builder:XXX
) in pytorch/pytorch, and then to come back and fix the image failures.