Skip to content

docs: added copyright holder to license file #1266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 11, 2024

Conversation

david-pa
Copy link
Contributor

@david-pa david-pa commented May 31, 2024

Fixes #902

Copy link

netlify bot commented May 31, 2024

Deploy Preview for pytorch-examples-preview canceled.

Name Link
🔨 Latest commit 86adbc6
🔍 Latest deploy log https://app.netlify.com/sites/pytorch-examples-preview/deploys/665a31e6b28a4800096805f6

Copy link

@spzala spzala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@david-pa thanks for the quick PR. Suggest to change your changes to Copyright (c) 2017, Pytorch contributors. Also, please mention the issue link in the PR description along with a brief description of the issue.
cc @msaroufim for review request.

@david-pa
Copy link
Contributor Author

@msaroufim Ready for review!

@david-pa
Copy link
Contributor Author

david-pa commented Jun 7, 2024

@pritamdamania87 @H-Huang please review.

Copy link

@spzala spzala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@david-pa thanks for addressing my comment. Changes looks good to me and in line with other repos.

@msaroufim
Copy link
Member

@spzala which other repos in PyTorch? I couldn't find this specific language and am not a lawyer to be able to understand the impact of simple verbiage changes to the license

@spzala
Copy link

spzala commented Jun 11, 2024

Hi @msaroufim yup :) but please see here https://github.com/pytorch/tutorials/blob/main/LICENSE

@msaroufim msaroufim self-requested a review June 11, 2024 18:40
@msaroufim msaroufim merged commit a38cbfc into pytorch:main Jun 11, 2024
@spzala
Copy link

spzala commented Jun 11, 2024

Thanks @msaroufim !!

YinZhengxun pushed a commit to YinZhengxun/mt-exercise-02 that referenced this pull request Mar 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

License file doesn't include any owner
4 participants