Added NNC lowering example #884
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesr66a
reviewed
Feb 5, 2021
| # | ||
| # NNC time: 0.0066373348236083984 | ||
| # PyTorch time 0.025979042053222656 | ||
| # Static Runtime time 0.011004209518432617 |
There was a problem hiding this comment.
Maybe put your lscpu in a gist so people know what machine these results come from
There was a problem hiding this comment.
Also, is Static Runtime public at all? If not, remove references to it
There was a problem hiding this comment.
Bram has made references to it on the PyTorch dev discussion forum, so I assume it's public.
There was a problem hiding this comment.
I put my CPU version
YinZhengxun
pushed a commit
to YinZhengxun/mt-exercise-02
that referenced
this pull request
Mar 30, 2025
Added NNC lowering example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taken from pytorch/pytorch#51130
Probably still need to add comments, but this is an annoying amount of code for a meaningfully commented example. Most of the lowering rules are obvious (about what they do), but it's still structured strangely.