Skip to content

Seemingly unnecessary dictionary comprehension in contrib's BaseOutputHandler #2438

Closed
@sadra-barikbin

Description

@sadra-barikbin

Hi,
output_dict is made sure to be a dictionary just above the line below.

metrics_state_attrs.update({name: value for name, value in output_dict.items()})

So this line could be replaced with:

metrics_state_attrs.update(output_dict) 

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions