Skip to content

Updated timers to include fired hanlders' times (#1104) #1194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 10, 2020
Merged

Updated timers to include fired hanlders' times (#1104) #1194

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
588c818
update timers including fired handlers ones
Jul 10, 2020
9499e16
autopep8 fix
Jul 10, 2020
7131f18
fix measurement and add test
Jul 10, 2020
f92da09
rename fire_start_time to handlers_start_time
Jul 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 17 additions & 10 deletions ignite/engine/engine.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -695,25 +695,32 @@ def _internal_run(self) -> State:
self._setup_engine()

time_taken = self._run_once_on_dataset()
# time is available for handlers but must be update after fire
self.state.times[Events.EPOCH_COMPLETED.name] = time_taken
if self.should_terminate:
self._fire_event(Events.TERMINATE)
else:
fire_start_time = time.time()
self._fire_event(Events.EPOCH_COMPLETED)
time_taken += time.time() - fire_start_time
# update time wrt handlers
self.state.times[Events.EPOCH_COMPLETED.name] = time_taken
hours, mins, secs = _to_hours_mins_secs(time_taken)
elapsed_time_message = "Epoch[%s] Complete. Time taken: %02d:%02d:%02d" % (
self.state.epoch,
hours,
mins,
secs,
self.logger.info(
"Epoch[%s] Complete. Time taken: %02d:%02d:%02d" % (self.state.epoch, hours, mins, secs)
)
if self.should_terminate:
self._fire_event(Events.TERMINATE)
self.logger.info(elapsed_time_message)
break
self._fire_event(Events.EPOCH_COMPLETED)
self.logger.info(elapsed_time_message)

time_taken = time.time() - start_time
hours, mins, secs = _to_hours_mins_secs(time_taken)
# time is available for handlers but must be update after fire
self.state.times[Events.COMPLETED.name] = time_taken
fire_start_time = time.time()
self._fire_event(Events.COMPLETED)
time_taken += time.time() - fire_start_time
# update time wrt handlers
self.state.times[Events.COMPLETED.name] = time_taken
hours, mins, secs = _to_hours_mins_secs(time_taken)
self.logger.info("Engine run complete. Time taken: %02d:%02d:%02d" % (hours, mins, secs))

except BaseException as e:
Expand Down