Skip to content

Move param handler #1988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
May 9, 2021
Merged

Move param handler #1988

merged 18 commits into from
May 9, 2021

Conversation

fco-dv
Copy link
Contributor

@fco-dv fco-dv commented May 5, 2021

Fixes #1912

Description: Move param_scheduler handlers to core part, ensuring BC until v6.0 in the contrib sub-module.

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@github-actions github-actions bot added module: contrib Contrib module module: handlers Core Handlers module labels May 5, 2021
@vfdev-5
Copy link
Collaborator

vfdev-5 commented May 6, 2021

@fco-dv how about doing things like for ClearML <-> Trains logger: https://github.com/pytorch/ignite/blob/master/ignite/contrib/handlers/trains_logger.py

Copy link
Contributor

@sdesrozis sdesrozis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fco-dv Thank you ! LGTM !

@vfdev-5
Copy link
Collaborator

vfdev-5 commented May 6, 2021

@fco-dv please update the docs. Take a look at what is rendered: https://deploy-preview-1988--pytorch-ignite-preview.netlify.app/

@vfdev-5
Copy link
Collaborator

vfdev-5 commented May 8, 2021

@fco-dv we also have to update versionadded same as @ydcjeff raised here: #1993

Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fco-dv !

@vfdev-5 vfdev-5 enabled auto-merge (squash) May 9, 2021 11:57
@vfdev-5 vfdev-5 merged commit c8541d7 into pytorch:master May 9, 2021
@fco-dv fco-dv deleted the move-param_handler branch May 9, 2021 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: contrib Contrib module module: handlers Core Handlers module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move param handlers to core part
3 participants