Some symbol annotation fixes for Windows #10369
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterjc123
requested review from
apaszke,
colesbury,
ezyang,
gchanan,
soumith and
zdevito
as code owners
ezyang
reviewed
Aug 9, 2018
| @@ -114,7 +114,7 @@ class AT_API Registry { | |||
| }; | |||
|
|
|||
| template <class SrcType, class ObjectPtrType, class... Args> | |||
| class AT_API Registerer { | |||
| class Registerer { | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
ezyang
reviewed
Aug 9, 2018
| @@ -119,7 +119,7 @@ def TypedDict(name, attrs, total=True): # type: ignore | |||
|
|
|||
| # add non-virtual declaration to Tensor.h | |||
| TENSOR_METHOD_DECLARATION = CodeTemplate("""\ | |||
| ${return_type} ${api_name}(${method_formals_with_defaults})${const_mark}; | |||
| AT_API ${return_type} ${api_name}(${method_formals_with_defaults})${const_mark}; | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
soumith
approved these changes
Aug 9, 2018
|
@ezyang Any more questions on this PR? |
|
let's land it |
There was a problem hiding this comment.
ezyang is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Aug 13, 2018
Summary: Pull Request resolved: pytorch/pytorch#10369 Differential Revision: D9300187 Pulled By: ezyang fbshipit-source-id: bf29966ad6aa221332b7232a965fb85e652f866d
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
Summary: Pull Request resolved: pytorch#10369 Differential Revision: D9300187 Pulled By: ezyang fbshipit-source-id: bf29966ad6aa221332b7232a965fb85e652f866d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.