mean pooling in EBC #1772
Closed
mean pooling in EBC #1772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D54656612 |
zainhuda
pushed a commit
to zainhuda/torchrec
that referenced
this pull request
Mar 8, 2024
Summary: this iteration turns 0 lengths to 1 prior to division Differential Revision: D54656612
zainhuda
force-pushed
the
export-D54656612
branch
from
5adba34 to
c0e6c6d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D54656612 |
zainhuda
force-pushed
the
export-D54656612
branch
from
c0e6c6d to
0a36272
Compare
zainhuda
pushed a commit
to zainhuda/torchrec
that referenced
this pull request
Mar 13, 2024
Summary: This diff supports mean pooling for Row Wise/Table Row Wise sharding schemes. This is achieved through applying mean pooling post reduce scatter collective as the KeyedTensor awaitable is created. The implementation is done through a callback. Differential Revision: D54656612
|
This pull request was exported from Phabricator. Differential Revision: D54656612 |
zainhuda
force-pushed
the
export-D54656612
branch
from
0a36272 to
bfd4ddb
Compare
zainhuda
pushed a commit
to zainhuda/torchrec
that referenced
this pull request
Mar 14, 2024
Summary: This diff supports mean pooling for Row Wise/Table Row Wise sharding schemes. This is achieved through applying mean pooling post reduce scatter collective as the KeyedTensor awaitable is created. The implementation is done through a callback. Differential Revision: D54656612
|
This pull request was exported from Phabricator. Differential Revision: D54656612 |
zainhuda
pushed a commit
to zainhuda/torchrec
that referenced
this pull request
Mar 14, 2024
Summary: This diff supports mean pooling for Row Wise/Table Row Wise sharding schemes. This is achieved through applying mean pooling post reduce scatter collective as the KeyedTensor awaitable is created. The implementation is done through a callback. Differential Revision: D54656612
zainhuda
force-pushed
the
export-D54656612
branch
from
bfd4ddb to
4feb1a9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D54656612 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D54656612 |
zainhuda
force-pushed
the
export-D54656612
branch
from
4feb1a9 to
f1e2a1a
Compare
zainhuda
pushed a commit
to zainhuda/torchrec
that referenced
this pull request
Mar 23, 2024
Summary: Pull Request resolved: pytorch#1772 This diff supports mean pooling for Row Wise/Table Row Wise sharding schemes. This is achieved through applying mean pooling post reduce scatter collective as the KeyedTensor awaitable is created. The implementation is done through a callback. Differential Revision: D54656612
|
This pull request was exported from Phabricator. Differential Revision: D54656612 |
zainhuda
pushed a commit
to zainhuda/torchrec
that referenced
this pull request
Mar 23, 2024
Summary: Pull Request resolved: pytorch#1772 This diff supports mean pooling for Row Wise/Table Row Wise sharding schemes. This is achieved through applying mean pooling post reduce scatter collective as the KeyedTensor awaitable is created. The implementation is done through a callback. Differential Revision: D54656612
zainhuda
force-pushed
the
export-D54656612
branch
from
f1e2a1a to
89fc1b2
Compare
|
This pull request was exported from Phabricator. Differential Revision: D54656612 |
zainhuda
pushed a commit
to zainhuda/torchrec
that referenced
this pull request
Mar 25, 2024
Summary: Pull Request resolved: pytorch#1772 This diff supports mean pooling for Row Wise/Table Row Wise sharding schemes. This is achieved through applying mean pooling post reduce scatter collective as the KeyedTensor awaitable is created. The implementation is done through a callback. Differential Revision: D54656612
zainhuda
force-pushed
the
export-D54656612
branch
from
89fc1b2 to
1ebeb0d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D54656612 |
zainhuda
pushed a commit
to zainhuda/torchrec
that referenced
this pull request
Mar 25, 2024
Summary: Pull Request resolved: pytorch#1772 This diff supports mean pooling for Row Wise/Table Row Wise sharding schemes. This is achieved through applying mean pooling post reduce scatter collective as the KeyedTensor awaitable is created. The implementation is done through a callback. Differential Revision: D54656612
zainhuda
force-pushed
the
export-D54656612
branch
from
1ebeb0d to
22ea8a3
Compare
zainhuda
pushed a commit
to zainhuda/torchrec
that referenced
this pull request
Mar 25, 2024
Summary: Pull Request resolved: pytorch#1772 This diff supports mean pooling for Row Wise/Table Row Wise sharding schemes. This is achieved through applying mean pooling post reduce scatter collective as the KeyedTensor awaitable is created. The implementation is done through a callback. Differential Revision: D54656612
zainhuda
force-pushed
the
export-D54656612
branch
from
22ea8a3 to
dd0bf12
Compare
|
This pull request was exported from Phabricator. Differential Revision: D54656612 |
|
This pull request was exported from Phabricator. Differential Revision: D54656612 |
zainhuda
pushed a commit
to zainhuda/torchrec
that referenced
this pull request
Mar 25, 2024
Summary: Pull Request resolved: pytorch#1772 This diff supports mean pooling for Row Wise/Table Row Wise sharding schemes. This is achieved through applying mean pooling post reduce scatter collective as the KeyedTensor awaitable is created. The implementation is done through a callback. Differential Revision: D54656612
zainhuda
force-pushed
the
export-D54656612
branch
2 times, most recently
from
909b87b to
2997b89
Compare
zainhuda
pushed a commit
to zainhuda/torchrec
that referenced
this pull request
Mar 28, 2024
Summary: This diff supports mean pooling for Row Wise/Table Row Wise sharding schemes. This is achieved through applying mean pooling post reduce scatter collective as the KeyedTensor awaitable is created. The implementation is done through a callback. Differential Revision: D54656612
|
This pull request was exported from Phabricator. Differential Revision: D54656612 |
zainhuda
pushed a commit
to zainhuda/torchrec
that referenced
this pull request
Mar 28, 2024
Summary: This diff supports mean pooling for Row Wise/Table Row Wise sharding schemes. This is achieved through applying mean pooling post reduce scatter collective as the KeyedTensor awaitable is created. The implementation is done through a callback. Differential Revision: D54656612
zainhuda
force-pushed
the
export-D54656612
branch
from
2997b89 to
c252dd9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D54656612 |
zainhuda
pushed a commit
to zainhuda/torchrec
that referenced
this pull request
Mar 28, 2024
Summary: This diff supports mean pooling for Row Wise/Table Row Wise sharding schemes. This is achieved through applying mean pooling post reduce scatter collective as the KeyedTensor awaitable is created. The implementation is done through a callback. Reviewed By: dstaay-fb Differential Revision: D54656612
zainhuda
force-pushed
the
export-D54656612
branch
from
c252dd9 to
c646c7d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D54656612 |
zainhuda
pushed a commit
to zainhuda/torchrec
that referenced
this pull request
Apr 1, 2024
Summary: This diff supports mean pooling for Row Wise/Table Row Wise sharding schemes. This is achieved through applying mean pooling post reduce scatter collective as the KeyedTensor awaitable is created. The implementation is done through a callback. Reviewed By: dstaay-fb Differential Revision: D54656612
zainhuda
force-pushed
the
export-D54656612
branch
from
c646c7d to
497260e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D54656612 |
zainhuda
pushed a commit
to zainhuda/torchrec
that referenced
this pull request
Apr 1, 2024
Summary: This diff supports mean pooling for Row Wise/Table Row Wise sharding schemes. This is achieved through applying mean pooling post reduce scatter collective as the KeyedTensor awaitable is created. The implementation is done through a callback. Reviewed By: dstaay-fb Differential Revision: D54656612
zainhuda
force-pushed
the
export-D54656612
branch
from
497260e to
3463eec
Compare
|
This pull request was exported from Phabricator. Differential Revision: D54656612 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D54656612 |
Summary: This diff supports mean pooling for Row Wise/Table Row Wise sharding schemes. This is achieved through applying mean pooling post reduce scatter collective as the KeyedTensor awaitable is created. The implementation is done through a callback. Reviewed By: dstaay-fb Differential Revision: D54656612
zainhuda
force-pushed
the
export-D54656612
branch
from
3463eec to
4ea42e2
Compare
|
This pull request was exported from Phabricator. Differential Revision: D54656612 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: this iteration turns 0 lengths to 1 prior to division
Differential Revision: D54656612