Skip to content

modify the placeholder attr parser to handle dict/list types #2181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

TroyGarden
Copy link
Contributor

Summary:

context

  • to handle complex ph_key for the placeholder like the following:
(Pdb) arg.op
'placeholder'
(Pdb) arg.ph_key
'event_id_list_features_seqs[marketplace]'
  • original workaround is to modify the arg_info in the _start_data_dist
(Pdb) forward.args
[ArgInfo(input_attrs=['event_id_list_features_seqs[user_conv_ads_event]'], is_getitems=[False], name=None)]
(Pdb) attr
'event_id_list_features_seqs[user_conv_ads_event]'
  • according to the ph_key generation, it could be something like A[key][idx].

Differential Revision: D59074268

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 26, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59074268

…#2181)

Summary:
Pull Request resolved: pytorch#2181

# context
* to handle complex ph_key for the placeholder like the following:
```
(Pdb) arg.op
'placeholder'
(Pdb) arg.ph_key
'event_id_list_features_seqs[marketplace]'
```
* original workaround is to modify the `arg_info` in the `_start_data_dist`
```
(Pdb) forward.args
[ArgInfo(input_attrs=['event_id_list_features_seqs[user_conv_ads_event]'], is_getitems=[False], name=None)]
(Pdb) attr
'event_id_list_features_seqs[user_conv_ads_event]'
```
* according to the ph_key generation, it could be something like `A[key][idx]`.

Differential Revision: D59074268
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59074268

@TroyGarden TroyGarden deleted the export-D59074268 branch August 8, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants