Faster KJT init (#2231) #2369
Closed
Faster KJT init (#2231) #2369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D62312329 |
|
This pull request was exported from Phabricator. Differential Revision: D62312329 |
dstaay-fb
added a commit
to dstaay-fb/torchrec
that referenced
this pull request
Sep 6, 2024
Summary: Pull Request resolved: pytorch#2369 Pull Request resolved: pytorch#2231 To improve inference, we want to make creating a KJT as cheap as possible, which means the init method is nothing more than a attribute setter. All other fields are calculated lazily. This is practicularly important wrt jit script and moving between compilation units. Differential Revision: D62312329
dstaay-fb
force-pushed
the
export-D62312329
branch
from
77a6b32 to
3da4a96
Compare
|
This pull request was exported from Phabricator. Differential Revision: D62312329 |
dstaay-fb
force-pushed
the
export-D62312329
branch
from
3da4a96 to
e9fd2c9
Compare
dstaay-fb
added a commit
to dstaay-fb/torchrec
that referenced
this pull request
Sep 6, 2024
Summary: Pull Request resolved: pytorch#2369 Pull Request resolved: pytorch#2231 To improve inference, we want to make creating a KJT as cheap as possible, which means the init method is nothing more than a attribute setter. All other fields are calculated lazily. This is practicularly important wrt jit script and moving between compilation units. Differential Revision: D62312329
Summary: Pull Request resolved: pytorch#2369 To improve inference, we want to make creating a KJT as cheap as possible, which means the init method is nothing more than a attribute setter. All other fields are calculated lazily. This is practicularly important wrt jit script and moving between compilation units. Differential Revision: D62312329
|
This pull request was exported from Phabricator. Differential Revision: D62312329 |
dstaay-fb
force-pushed
the
export-D62312329
branch
from
e9fd2c9 to
7885a2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
To improve inference, we want to make creating a KJT as cheap as possible, which means the init method is nothing more than a attribute setter. All other fields are calculated lazily. This is practicularly important wrt jit script and moving between compilation units.
Differential Revision: D62312329