add PT2 support for permute_multi_embedding #2381
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D62226292 |
|
This pull request was exported from Phabricator. Differential Revision: D62226292 |
TroyGarden
added a commit
to TroyGarden/torchrec
that referenced
this pull request
Sep 11, 2024
Summary: Pull Request resolved: pytorch#2381 It looks like test_pt2 already passed. not sure why the test can't capture the PT2 incompatibility in the op. graph breaks: P1557581728 https://interncache-all.fbcdn.net/manifold/tlparse_reports/tree/logs/.tmphgx6wM/rank_0/failures_and_restarts.html Differential Revision: D62226292
TroyGarden
force-pushed
the
export-D62226292
branch
from
dd99f14 to
dfadd39
Compare
Summary: Pull Request resolved: pytorch#2381 # context * make fbgemm operator `permute_multi_embedding` PT2 compatible. * `out_lengths` is the list of sizes for all the output KT, which should be dynamic dims. * change the `out_lengths` from `std::vector<int64_t>` to `c10::SymIntArrayRef`, and other type compatibility fixes. # ref graph breaks: P1557581728 https://interncache-all.fbcdn.net/manifold/tlparse_reports/tree/logs/.tmphgx6wM/rank_0/failures_and_restarts.html Reviewed By: IvanKobzarev Differential Revision: D62226292
|
This pull request was exported from Phabricator. Differential Revision: D62226292 |
TroyGarden
force-pushed
the
export-D62226292
branch
from
dfadd39 to
453f928
Compare
TroyGarden
added a commit
to TroyGarden/FBGEMM
that referenced
this pull request
Sep 12, 2024
Summary: X-link: pytorch/torchrec#2381 # context * make fbgemm operator `permute_multi_embedding` PT2 compatible. * `out_lengths` is the list of sizes for all the output KT, which should be dynamic dims. * change the `out_lengths` from `std::vector<int64_t>` to `c10::SymIntArrayRef`, and other type compatibility fixes. # ref graph breaks: P1557581728 https://interncache-all.fbcdn.net/manifold/tlparse_reports/tree/logs/.tmphgx6wM/rank_0/failures_and_restarts.html Reviewed By: IvanKobzarev Differential Revision: D62226292
facebook-github-bot
pushed a commit
to pytorch/FBGEMM
that referenced
this pull request
Sep 12, 2024
Summary: X-link: facebookresearch/FBGEMM#208 Pull Request resolved: #3115 X-link: pytorch/torchrec#2381 # context * make fbgemm operator `permute_multi_embedding` PT2 compatible. * `out_lengths` is the list of sizes for all the output KT, which should be dynamic dims. * change the `out_lengths` from `std::vector<int64_t>` to `c10::SymIntArrayRef`, and other type compatibility fixes. # ref * previously graph breaks: P1557581728 https://interncache-all.fbcdn.net/manifold/tlparse_reports/tree/logs/.tmphgx6wM/rank_0/failures_and_restarts.html * new https://interncache-all.fbcdn.net/manifold/tlparse_reports/tree/logs/.tmpxLBHmj/index.html Reviewed By: IvanKobzarev Differential Revision: D62226292 fbshipit-source-id: c826309939e0a33190b49a3aa090cbcc7515b20d
q10
pushed a commit
to q10/FBGEMM
that referenced
this pull request
Apr 10, 2025
Summary: Pull Request resolved: facebookresearch/FBGEMM#208 X-link: pytorch#3115 X-link: pytorch/torchrec#2381 # context * make fbgemm operator `permute_multi_embedding` PT2 compatible. * `out_lengths` is the list of sizes for all the output KT, which should be dynamic dims. * change the `out_lengths` from `std::vector<int64_t>` to `c10::SymIntArrayRef`, and other type compatibility fixes. # ref * previously graph breaks: P1557581728 https://interncache-all.fbcdn.net/manifold/tlparse_reports/tree/logs/.tmphgx6wM/rank_0/failures_and_restarts.html * new https://interncache-all.fbcdn.net/manifold/tlparse_reports/tree/logs/.tmpxLBHmj/index.html Reviewed By: IvanKobzarev Differential Revision: D62226292 fbshipit-source-id: c826309939e0a33190b49a3aa090cbcc7515b20d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
It looks like test_pt2 already passed. not sure why the test can't capture the PT2 incompatibility in the op.
graph breaks: P1557581728
https://interncache-all.fbcdn.net/manifold/tlparse_reports/tree/logs/.tmphgx6wM/rank_0/failures_and_restarts.html
Differential Revision: D62226292