Skip to content

torchx/notebook: added workspacefile magic for use with notebooks #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

d4l3k
Copy link
Member

@d4l3k d4l3k commented Nov 18, 2021

This adds the notebook workspace magic/helpers as described in #344

Test plan:

pytest torchx/test/notebook_test.py
pyre

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 18, 2021
@facebook-github-bot
Copy link
Contributor

@d4l3k has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@codecov
Copy link

codecov bot commented Nov 18, 2021

Codecov Report

Merging #356 (95b1970) into main (0f81544) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #356      +/-   ##
==========================================
+ Coverage   94.55%   94.58%   +0.02%     
==========================================
  Files          59       60       +1     
  Lines        3084     3101      +17     
==========================================
+ Hits         2916     2933      +17     
  Misses        168      168              
Impacted Files Coverage Δ
torchx/notebook.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f81544...95b1970. Read the comment docs.

@facebook-github-bot
Copy link
Contributor

@d4l3k merged this pull request in a9c1a3d.

@d4l3k d4l3k deleted the torchxnotebook branch February 1, 2022 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants