Skip to content

update to torch 1.11, python 3.10 #423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

update to torch 1.11, python 3.10 #423

wants to merge 1 commit into from

Conversation

d4l3k
Copy link
Member

@d4l3k d4l3k commented Mar 15, 2022

Now that torch 1.11 is released we should update to it. Also adds python 3.10 support to the unit tests now that torch supports it.

Ray doesn't support Python 3.10 so we exclude it from dev-requirements on 3.10. ray-project/ray#21221

Test plan:

CI

torchx/runtime/container/build.sh

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 15, 2022
@d4l3k d4l3k force-pushed the torch111 branch 3 times, most recently from 70061c4 to 0ed3b9f Compare March 15, 2022 19:24
@codecov
Copy link

codecov bot commented Mar 15, 2022

Codecov Report

Merging #423 (50c1317) into main (4cd94d8) will increase coverage by 0.10%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #423      +/-   ##
==========================================
+ Coverage   94.29%   94.40%   +0.10%     
==========================================
  Files          67       67              
  Lines        3805     3805              
==========================================
+ Hits         3588     3592       +4     
+ Misses        217      213       -4     
Impacted Files Coverage Δ
torchx/schedulers/ray/ray_driver.py 98.03% <ø> (ø)
torchx/specs/api.py 99.00% <100.00%> (ø)
torchx/runner/events/__init__.py 91.66% <0.00%> (-2.78%) ⬇️
torchx/schedulers/ray_scheduler.py 96.21% <0.00%> (+2.27%) ⬆️
torchx/runner/events/api.py 69.23% <0.00%> (+5.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cd94d8...50c1317. Read the comment docs.

@facebook-github-bot
Copy link
Contributor

@d4l3k has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@d4l3k d4l3k added this to the 0.1.2 release milestone Mar 22, 2022
@d4l3k d4l3k deleted the torch111 branch April 13, 2022 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants