-
Notifications
You must be signed in to change notification settings - Fork 132
schedulers/aws_batch: fix thread local sessions + raise error on missing memory resource #430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #430 +/- ##
==========================================
+ Coverage 94.41% 94.57% +0.16%
==========================================
Files 67 67
Lines 3830 3836 +6
==========================================
+ Hits 3616 3628 +12
+ Misses 214 208 -6
Continue to review full report at Codecov.
|
@d4l3k has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@d4l3k has updated the pull request. You must reimport the pull request before landing. |
@d4l3k has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@d4l3k has updated the pull request. You must reimport the pull request before landing. |
@d4l3k has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@d4l3k has updated the pull request. You must reimport the pull request before landing. |
…ing memory resource
@d4l3k has updated the pull request. You must reimport the pull request before landing. |
@d4l3k has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
This behavior was noticed in #429 and this is intended to clean it up.
Previously the thread local logic was incorrect so we would create a new session for every request which caused a lot of spam:
Test plan:
Updated unit tests