Skip to content

docs: document .torchxconfig usage with component: #434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

d4l3k
Copy link
Member

@d4l3k d4l3k commented Mar 25, 2022

This documents .torchxconfig [component:foo] defaults.

Test plan:

Screenshot 2022-03-25 at 15-53-37  torchxconfig — PyTorch TorchX main documentation

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 25, 2022
@facebook-github-bot
Copy link
Contributor

@d4l3k has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@codecov
Copy link

codecov bot commented Mar 25, 2022

Codecov Report

Merging #434 (bcf455f) into main (434c013) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #434   +/-   ##
=======================================
  Coverage   94.52%   94.52%           
=======================================
  Files          64       64           
  Lines        3782     3782           
=======================================
  Hits         3575     3575           
  Misses        207      207           
Impacted Files Coverage Δ
torchx/runner/config.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 434c013...bcf455f. Read the comment docs.

@d4l3k d4l3k force-pushed the componentconfigdocs branch from 017a62b to bcf455f Compare March 25, 2022 23:16
@facebook-github-bot
Copy link
Contributor

@d4l3k has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@d4l3k has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@d4l3k d4l3k deleted the componentconfigdocs branch April 13, 2022 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants