Skip to content

Improve whites in cira stretch #3130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mraspaud
Copy link
Member

This PR improve the brightness of clouds in Cira stretch.

See comments for examples.

  • Closes #xxxx
  • Tests added
  • Fully documented
  • Add your name to AUTHORS.md if not there already

@mraspaud mraspaud self-assigned this May 14, 2025
@mraspaud mraspaud requested a review from djhoese as a code owner May 14, 2025 13:20
@mraspaud mraspaud added enhancement code enhancements, features, improvements component:enhancements labels May 14, 2025
@mraspaud
Copy link
Member Author

mraspaud commented May 14, 2025

Original cira stretch (main):
fd100

new version (this PR)
fd80

@coveralls
Copy link

Pull Request Test Coverage Report for Build 15021807021

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.326%

Totals Coverage Status
Change from base Build 15005538775: 0.0%
Covered Lines: 55425
Relevant Lines: 57539

💛 - Coveralls

@djhoese
Copy link
Member

djhoese commented May 14, 2025

What sparked this change? I think this should be a separate enhancement or something configurable or I don't know. I don't like that this long standing enhancement is changing internally and in an "arbitrary"/non-math way. You could also use the enhancement that we've been using in Geo2Grid for a long time due to this same washed out cloud issue:

https://github.com/ssec/polar2grid/blob/93e3f63dc9cc0379ba3e83b3779ea2278dc9d7ac/polar2grid/etc/enhancements/abi.yaml#L2-L14

Copy link

codecov bot commented May 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.22%. Comparing base (4dd516f) to head (055238b).
Report is 81 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #3130    +/-   ##
========================================
  Coverage   96.21%   96.22%            
========================================
  Files         396      398     +2     
  Lines       56910    57330   +420     
========================================
+ Hits        54756    55165   +409     
- Misses       2154     2165    +11     
Flag Coverage Δ
behaviourtests 3.88% <0.00%> (-0.03%) ⬇️
unittests 96.31% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ameraner
Copy link
Member

Ping @strandgren if you also played around with similar things?

@mraspaud
Copy link
Member Author

mraspaud commented May 14, 2025

What sparked this change? I think this should be a separate enhancement or something configurable or I don't know. I don't like that this long standing enhancement is changing internally and in an "arbitrary"/non-math way. You could also use the enhancement that we've been using in Geo2Grid for a long time due to this same washed out cloud issue:

https://github.com/ssec/polar2grid/blob/93e3f63dc9cc0379ba3e83b3779ea2278dc9d7ac/polar2grid/etc/enhancements/abi.yaml#L2-L14

Yes, it's an arbitrary decision indeed.
The thought was clouds were looking grey, so we wanted to fix it, and do it at the same time as other changes triggered by the RGB workshop conclusions.
However, I just looked at the RGB workshop recipe for true color and it goes against what I did here (range 0-100, not 0-80 as implemented here), so I think I will go with what you suggest and make in configurable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:enhancements enhancement code enhancements, features, improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants