Implementing visit_while_loop #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

TheGupta2012 merged 22 commits into qBraid:main from bhagyasreey:add-while-loop-support

Jun 16, 2025

Contributor

bhagyasreey commented Jun 12, 2025 •

edited by TheGupta2012

Loading

Fixes #7

Summary of changes

_visit_while_loop Method

Implements logic to simulate execution of a while loop during AST traversal.
Supports break and continue control flow inside the loop body.
Uses a counter (loop_counter) to prevent infinite loops via a max_iterations threshold.
Evaluates the loop condition using Qasm3ExprEvaluator.evaluate_expression(...).

LoopControlSignal Handling

Custom mechanism to simulate break and continue:
These are raised by statement visitors like visit_break and visit_continue.

Loop Safety Mechanism

Hardcoded max_iterations (e.g., 1024) to avoid infinite loops.
Raises a custom exception like LoopLimitExceededError if the loop exceeds the limit.


          Add unroll_loops support to while loop handling

6d40d42

bhagyasreey requested a review from TheGupta2012 as a code owner

June 12, 2025 04:37

codecov-commenter commented Jun 12, 2025 •

edited

Loading

Codecov Report

Attention: Patch coverage is 96.25000% with 3 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/pyqasm/analyzer.py	80.00%	3 Missing ⚠️

📢 Thoughts on this report? Let us know!

bhagyasreey added 4 commits

June 12, 2025 10:15


          Update test.py

1d86010


          Update visitor.py

83bde5f


          Update visitor.py

d5dae9c


          Update visitor.py

52c99dd

TheGupta2012 reviewed

View reviewed changes

src/pyqasm/visitor.py Outdated Show resolved Hide resolved

TheGupta2012 reviewed

View reviewed changes

src/pyqasm/visitor.py Outdated Show resolved Hide resolved

TheGupta2012 reviewed

View reviewed changes

src/pyqasm/visitor.py Outdated Show resolved Hide resolved

TheGupta2012 reviewed

View reviewed changes

src/pyqasm/visitor.py Outdated Show resolved Hide resolved

TheGupta2012 reviewed

View reviewed changes

src/pyqasm/visitor.py Show resolved Hide resolved

TheGupta2012 reviewed

View reviewed changes

tests/test.py Outdated Show resolved Hide resolved

TheGupta2012 requested changes

View reviewed changes

Member

TheGupta2012 left a comment

Hi @bhagyasreey , thanks for the work! I've reviewed and provided some suggestions for the code, could you please take a look?

bhagyasreey added 15 commits

June 13, 2025 20:03


          Update test.py

7fe2fdb


          Create test_while.py

4fb0a35


          Delete tests/test.py

098d175


          Update visitor.py

ed78c70


          Update exceptions.py

958e9dd


          Update visitor.py

748f832


          Update test_while.py

738bbf3


          Update exceptions.py

7fa72a7


          Update visitor.py

439a494


          Update exceptions.py

00d9617


          Update visitor.py

ef8ec1e


          Update visitor.py

7224ede


          Update test_while.py

8314ce3


          Update test_while.py

2b4282b


          Update test_while.py

8dcce92

Contributor Author

bhagyasreey commented Jun 14, 2025

@TheGupta2012 could you please check the changes. Thank you.

Member

TheGupta2012 commented Jun 14, 2025

Hi, could you look into the tests failure please?


          Update test_while.py

3709c33

Contributor Author

bhagyasreey commented Jun 14, 2025

I fixed the issue. Could you please check it now.


          finalize PR

c18d754

TheGupta2012 self-requested a review

June 16, 2025 06:26

TheGupta2012 approved these changes

View reviewed changes

Member

TheGupta2012 left a comment

LGTM

TheGupta2012 merged commit 8b04215 into qBraid:main

20 checks passed

TheGupta2012 mentioned this pull request

[FEATURE] Add max_loop iteration limit in _visit_forin_loop #208

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet