-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
This closes #2024, add TempDir field in the Options data type (#2024) #2163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Change-Id: I96e24738982be893c8a52783069221b9abeff2cf Signed-off-by: mengzhongyuan <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2163 +/- ##
=======================================
Coverage 99.23% 99.23%
=======================================
Files 32 32
Lines 30378 30379 +1
=======================================
+ Hits 30147 30148 +1
Misses 153 153
Partials 78 78
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Change-Id: Ia9dd626e88b9540afe8c1077205c400cbe40c0af Signed-off-by: mengzhongyuan <[email protected]>
Change-Id: I9c26214ccf8f48aa2c56356a2ff75364e445459b Signed-off-by: mengzhongyuan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds the ability to specify a custom temporary directory for excelize operations, ensuring that streaming writer temp files and unzipped files are created in the desired location rather than the default OS temporary directory.
- Introduces a new Options field (TmpDir) and updates file creation functions to utilize it.
- Updates tests to validate behavior when using a specific temp directory.
- Modifies several core files (stream.go, rows.go, lib.go, excelize.go) and relevant tests (stream_test.go, lib_test.go) to support this functionality.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
stream_test.go | Added tests to verify that temp files are created and then removed based on the provided temp directory. |
stream.go | Updated the streaming writer to set a custom temp directory when provided. |
rows.go | Uses the custom temp directory for creating shared string temp file. |
lib_test.go | Added unzip-related test to validate temp file creation in a specific directory. |
lib.go | Updated unzipToTemp to use the custom temp directory if provided. |
excelize.go | Extended Options to include the TmpDir property for temporary file location. |
Change-Id: I227385384f81dba8cb013315896e6e93a6412814 Signed-off-by: mengzhongyuan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution.
Change-Id: I96e24738982be893c8a52783069221b9abeff2cf
PR Details
Description
Close #2024, add temp dir file option.
Related Issue
#2024
Motivation and Context
How Has This Been Tested
Types of changes
Checklist