use Jsonitor instead of encoding/json #285
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewei1316
reviewed
Jan 3, 2018
parser/csv_parser.go
Outdated
| @@ -37,6 +37,11 @@ const ( | |||
|
|
|||
| const MaxParserSchemaErrOutput = 5 | |||
|
|
|||
| var jsontool = jsoniter.Config{ | |||
| EscapeHTML: true, | |||
There was a problem hiding this comment.
这个字段是指忽略 html ? 会不会影响用户的数据？
andrewei1316
reviewed
Jan 3, 2018
| } | ||
|
|
||
| func NewJsonParser(c conf.MapConf) (LogParser, error) { | ||
| name, _ := c.GetStringOr(KeyParserName, "") | ||
| labelList, _ := c.GetStringListOr(KeyLabels, []string{}) | ||
| nameMap := map[string]struct{}{} | ||
| labels := GetLabels(labelList, nameMap) | ||
| jsontool := jsoniter.Config{ | ||
| EscapeHTML: true, |
There was a problem hiding this comment.
EscapeHTML是json标准库默认的行为
|
发现了一个jsoniter不适配的地方：json-iterator/go#217 |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes [issue number]
Changes
主要集中在2个优势
Reviewers
Wiki Changes
Checklist