-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Bump the proto requirements to match the generated data. #4473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
CirqBot
merged 16 commits into
quantumlib:master
from
tonybruguier:cirq_bump_proto_version
Sep 10, 2021
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
c48b985
Bump proto version
tonybruguier 62ccde7
Merge branch 'master' of github.com:quantumlib/Cirq into cirq_bump_pr…
tonybruguier 56f7678
Re-generate proto API
tonybruguier 75f54e1
Try regeneration again
tonybruguier 2bc60ef
Merge branch 'master' of github.com:quantumlib/Cirq into cirq_bump_pr…
tonybruguier 2f5fd76
Regenerate again
tonybruguier 574a589
Update dev tool deps for protos
tonybruguier 136c7ee
Maybe check all protos
tonybruguier fc7b8b5
More debug code
tonybruguier 5c437db
Directly call the the building script
tonybruguier 7d4ce89
Address some comments
tonybruguier 60123dd
Purposely mangle the protos to make sure the test catches this
tonybruguier ca6b6f0
Re-generate protos to undo the mangling
tonybruguier 1531442
Merge branch 'master' of github.com:quantumlib/Cirq into cirq_bump_pr…
tonybruguier 96ff28b
Merge branch 'master' of github.com:quantumlib/Cirq into cirq_bump_pr…
tonybruguier a23ea74
Address comments
tonybruguier File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,2 @@ | ||
google-api-core[grpc] >= 1.14.0, < 2.0.0dev | ||
protobuf~=3.13.0 | ||
protobuf>=3.13.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,6 @@ | ||
# dependencies for proto generation - used by cirq-google | ||
|
||
# 1.26.0 is the min version that has python 3.8 wheels | ||
# however, we can't really go much higher - the protoc version needs to be <= 3.9.2 | ||
# otherwise it will generate pb2 files that are incompatible with tensorflow quantum | ||
grpcio-tools~=1.26.0 | ||
# This bundles protoc 3.13.0, which we use for generating proto code. | ||
grpcio-tools~=1.34.1 | ||
tonybruguier marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
mypy-protobuf==1.10 |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.