Fix bug in controlled() method of CCX and CCZ gates #6237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #6237 +/- ##
==========================================
- Coverage 97.38% 97.37% -0.01%
==========================================
Files 1116 1116
Lines 96157 96174 +17
==========================================
+ Hits 93638 93651 +13
- Misses 2519 2523 +4
☔ View full report in Codecov by Sentry. |
dstrain115
approved these changes
Aug 10, 2023
|
|
||
| def test_assert_controlled_unitary_consistent(): | ||
| cirq.testing.assert_controlled_and_controlled_by_identical( | ||
| GoodGate(exponent=0.5, global_shift=1 / 3) |
There was a problem hiding this comment.
Worth testing with global_shift=0, or is that covered somewhere else?
There was a problem hiding this comment.
global_shift = 0 is a strictly simpler case. And this is a test to make sure assert_controlled_and_controlled_by_identical is doing the right thing, not to test the correctness of GoodGate and BadGate. We have tests for global_shift=0 and global_shift != 0 for CCX / CCZ etc., so I think this should be sufficient.
harry-phasecraft
pushed a commit
to PhaseCraft/Cirq
that referenced
this pull request
Oct 31, 2024
* Fix bug in controlled() method of CCX and CCZ gates * Fix typing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6235
Also adds a consistency test
assert_controlled_unitary_consistentto the standard suite ofassert_implements_consistent_protocolsto make sure unitaries ofgate.controlled()andControlledGate()are identical. This consistency test would have caught the bug in the original PR.