Skip to content

Update type checks to include NumPy numeric types #961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

peter-janderks
Copy link

isinstance(np.int64(1), int)) returns False for numpy 2.3.0 while it returns True for numpy 2.2.0 and earlier versions.
This caused AnonTaskStasts to raise an AssertionError.

@Strilanc
Copy link
Collaborator

Blergh this probably affects my code in so many places...

Thanks for the fix!

@peter-janderks
Copy link
Author

I didn't catch other lines that needed to be updated because I didn't actually run the sinter test.
pip install . didn't work on my apple device running Clang 16. This was fixed by updating to Apple clang version 17.0.0.
The tests passed on my device.

@peter-janderks
Copy link
Author

peter-janderks commented Jun 19, 2025

I didn't check python dev/doctest_proper.py --module sinter 🤦

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants