Skip to content

Profile updates for EVs #3110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 5, 2024
Merged

Profile updates for EVs #3110

merged 7 commits into from
Sep 5, 2024

Conversation

kaskranenburgQ
Copy link
Contributor

@kaskranenburgQ kaskranenburgQ commented Aug 29, 2024

This PR changes the profiles for electric vehicles.

  • It changes the mapping of the profiles:

    '- electric_vehicle_profile_1: Charging in public
    '- electric_vehicle_profile_2 : Charging at home
    '- electric_vehicle_profile_3 : Fast charging
    '- electric_vehicle_profile_4 : Charging at work
    '- electric_vehicle_profile_5 Custom profile

It updates the profiles electric_vehicle_profile_1, electric_vehicle_profile_2, electric_vehicle_profile_4 to ev profiles generated by Elaad. electric_vehicle_profile_5 is converted to a flat profile that can be overwritten by the users.

Lastly, the standard settings in all datasets have been updated to the following settings:

electric_vehicle_profile_1_share': 0.24
 electric_vehicle_profile_2_share': '0.56'
electric_vehicle_profile_3_share': '0.08'
electric_vehicle_profile_4_share': '0.12'
electric_vehicle_profile_5_share': '0.0'

Goes together with:

@kndehaan kndehaan self-requested a review August 29, 2024 07:32
@mabijkerk mabijkerk changed the title Dsr ev Profile updates for EVs Aug 29, 2024
@mabijkerk
Copy link
Member

mabijkerk commented Aug 29, 2024

@kaskranenburgQ instead of a flat curve for profile 5, should we consider something a bit more representative for EV charging? For example, charging at home.

@mabijkerk
Copy link
Member

What I noticed from this PR is that Ameland has its own curve set. Diving into Github shows that this was done in 9891b7c to correct for seasonal tourist variation.

@DorinevanderVlies you have applied these changes. Are you okay with changes to Ameland being made? Most curves already seem to have been overwritten, for example in 01ded54.

Copy link
Contributor

@kndehaan kndehaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, no comments

@mabijkerk
Copy link
Member

@kaskranenburgQ I think dk, de and eu should also be assigned the new curves. Additionally, for UKNI01_northern_ireland, electric_vehicle_profile_4 does not seem to be updated. Is that intentional?

@DorinevanderVlies
Copy link
Contributor

@DorinevanderVlies you have applied these changes. Are you okay with changes to Ameland being made? Most curves already seem to have been overwritten, for example in 01ded54.

It's ok to overwrite the EV curves for Ameland!

Copy link
Member

@mabijkerk mabijkerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Check electric profile curve 4 for Northern Ireland
  • Check electric profile curves for eu, dk and de
  • Determine whether or not to update electric profile curve 5 from flat to a more representative base curve

@kaskranenburgQ
Copy link
Contributor Author

kaskranenburgQ commented Aug 29, 2024

@mabijkerk

[ ] Determine whether or not to update electric profile curve 5 from flat to a more representative base curve

I discussed this with @jorisberkhout earlier, we concluded that it would be more clear to initally show a flat curve at the custom curve.

@kaskranenburgQ kaskranenburgQ merged commit 00c9dd4 into master Sep 5, 2024
1 check passed
@kaskranenburgQ kaskranenburgQ deleted the dsr-ev branch September 5, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants