Skip to content

Update derive_more requirement from 0.99 to 2.0 #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update derive_more requirement from 0.99 to 2.0 #294

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion protocol/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ ordered-float = "4.1.0"
uuid = "1"
chrono = "0.4.26"
num_enum = "0.7.0"
derive_more = "0.99"
derive_more = { version = "2.0.1", features = ["full"] }

[dev-dependencies]
pretty_assertions = "1.2.0"
Expand Down
6 changes: 3 additions & 3 deletions protocol/src/message/amqp/types/primitives/value.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,9 +180,9 @@
fn try_from(value: &'a Value) -> Result<Self, Self::Error> {
use std::convert::TryInto;
match value {
Value::Simple(simple) => simple
.try_into()
.map_err(|err: &str| DecodeError::MessageParse(err.to_string())),
Value::Simple(simple) => simple.try_into().map_err(|_| {
DecodeError::MessageParse("Failed to cast Value to simple type".to_string())
}),

Check warning on line 185 in protocol/src/message/amqp/types/primitives/value.rs

View check run for this annotation

Codecov / codecov/patch

protocol/src/message/amqp/types/primitives/value.rs#L183-L185 

Added lines #L183 - L185 were not covered by tests
_ => Err(DecodeError::MessageParse(
"Failed to cast Value to simple type".to_string(),
)),
Expand Down
Loading