Configure fail safe mechanism #93
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes the fail safe mechanism optional. When fail safe is disabled, errors will be raised as per usual.
* main: Coalesce "current pipeline or redis" into the redis method itself Pefer a thread_mattr_accessor over a thread local variable Delete list of keys in batch (rails#90) Use a thread-local variable for pipeline Revert "Use block parameter to pipeline in Redis#multi (rails#68)" Resolve pipelining deprecation warnings
intrip
reviewed
Jul 4, 2022
| end | ||
|
|
||
| def failsafe | ||
| yield | ||
| def failsafe(returning: nil, &block) |
There was a problem hiding this comment.
What about changing failsafe(returning: nil, &block) API to failsafe(returning: nil, errors: [Redis::BaseError], &block) such that we make explicit which errors we catch?
|
Closing in favor of #94 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
Adds a fail safe configuration mechanism