Skip to content

Fix detection for .mdb and .accdb files #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 17, 2021
Merged

Fix detection for .mdb and .accdb files #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions lib/marcel/mime_type/definitions.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,3 +42,13 @@
Marcel::MimeType.extend "application/vnd.adobe.flash.movie", magic: [[0, "FWS"], [0, "CWS"]], extensions: %w( swf )
Marcel::MimeType.extend "application/sql", extensions: %w( sql )
Marcel::MimeType.extend "text/vcard", magic: [[0, "BEGIN:VCARD"]], extensions: %w( vcf ), parents: "text/plain"

Marcel::MimeType.extend(
"application/vnd.ms-access",
extensions: %w( mdb accdb ),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gmcgibbon I missed this - should mde and accde be in this list too? They're the compiled versions of mdb and accdb files.

Copy link
Member Author

@gmcgibbon gmcgibbon May 17, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could add those extensions, but it also depends what the hexdumped contents are for magic detection. I'll try playing with a trial of MS access to see if I can get more fixtures to test out.

magic: [
[0, "\x00\x01\x00\x00\x53\x74\x61\x6e\x64\x61\x72\x64\x20\x4a\x65\x74\x20\x44\x42"], # \x00\x01\x00\xStandard Jet DB
[0, "\x00\x01\x00\x00\x53\x74\x61\x6e\x64\x61\x72\x64\x20\x41\x43\x45\x20\x44\x42"], # \x00\x01\x00\xStandard ACE DB
],
parents: "application/x-msaccess"
)
Binary file added test/fixtures/magic/application/vnd.ms-access/db.accdb
View file
Open in desktop
Binary file not shown.
Binary file added test/fixtures/magic/application/vnd.ms-access/db.mdb
View file
Open in desktop
Binary file not shown.
Binary file added test/fixtures/name/application/vnd.ms-access/db.accdb
View file
Open in desktop
Binary file not shown.
Binary file added test/fixtures/name/application/vnd.ms-access/db.mdb
View file
Open in desktop
Binary file not shown.