Skip to content

Suppress warnings when running "gem build marcel.gemspec" #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 4, 2018

Conversation

junaruga
Copy link
Contributor

@junaruga junaruga commented May 4, 2018

  • Suppress warnings when running "gem build marcel.gemspec".
  • Typo filenames => file names.

Right now there are warnings, running gem build marcel.gemspec.
I fixed the warnings.
I also changed a small typo "filenames" to "file names" to use words in dictionary.

$ gem build marcel.gemspec
WARNING:  open-ended dependency on minitest (>= 0, development) is not recommended
  if minitest is semantically versioned, use:
    add_development_dependency 'minitest', '~> 0'
WARNING:  pessimistic dependency on rack (~> 2.0.1, development) may be overly strict
  if rack is semantically versioned, use:
    add_development_dependency 'rack', '~> 2.0', '>= 2.0.1'
WARNING:  See http://guides.rubygems.org/specification-reference/ for help
  Successfully built RubyGem
  Name: marcel
  Version: 0.3.2
  File: marcel-0.3.2.gem

@junaruga junaruga force-pushed the feature/text-typo-file-names branch from 94cd616 to 40d663b Compare May 4, 2018 10:43
@junaruga
Copy link
Contributor Author

junaruga commented May 4, 2018

I updated Gemfile.lock too. But do we really need to manage the file? Can we remove the file from the repository?

I think that managing the dependency packages and the version with only rubygem-marcel.spec and Gemfile might be better.

marcel.gemspec Outdated
@@ -8,7 +8,7 @@ Gem::Specification.new do |spec|
spec.version = Marcel::VERSION
spec.authors = ['Tom Ward']
spec.email = ['[email protected]']
spec.summary = %q{Simple mime type detection using magic numbers, filenames, and extensions}
spec.summary = %q{Simple mime type detection using magic numbers, file names, and extensions}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please leave this line alone. This change is not necessary to suppress gem build warnings.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@georgeclaghorn ok rebased!

@junaruga junaruga force-pushed the feature/text-typo-file-names branch from 40d663b to ac3f271 Compare May 4, 2018 16:18
@junaruga
Copy link
Contributor Author

junaruga commented May 4, 2018

Please leave this line alone. This change is not necessary to suppress gem build warnings.

Here is a PR to leave the line alone. #9

@georgeclaghorn georgeclaghorn merged commit d1471cc into rails:master May 4, 2018
@junaruga junaruga deleted the feature/text-typo-file-names branch May 4, 2018 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants