Check the type of the default #435
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It should match the type of the option.
|
Nice! |
|
I believe this will be a breaking change to some project. While they can forward fix the mismatch in the type the current releases of those project will now start to raise errors when loading the generator. This was the case of rails rails/rails#22789. I agree this is a good change but I think we should release it in a non-backward compatible release. Maybe a warning instead of an exception for the current release? |
|
@rafaelfranca comment above is spot on and is the cause of issue #533 |
sferik
added a commit
that referenced
this pull request
Nov 27, 2016
sferik
added a commit
that referenced
this pull request
Nov 27, 2016
sferik
added a commit
that referenced
this pull request
Nov 27, 2016
purecodecoach
added a commit
to purecodecoach/thor
that referenced
this pull request
Jan 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I think the default option should match the type. This is a problem I ran into while using Thor. I had code like this:
I expect the default value
'50'to be a numeric, but of course it was a string.Hopefully, this pull request solves the problem. ;-)
Cheers,
Huw.