ASoC: DACplus - fix 16bit sample support in clock consumer mode #5917
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The former code did not adjust the physical sample width when in clock consumer mode and has taken the fixed 32 bit default. This has caused the audio to be played at half its frequency due to the fixed bclk_ratio of 64. Signed-off-by: Joerg Schambacher <[email protected]>
|
Thanks, Phil! Will do the same for DAC+ADC Pro. |
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Feb 7, 2024
kernel: Improve I2C timing (again) See: raspberrypi/linux#5916 kernel: drm/vc4: Drop planes that have 0 destination size See: raspberrypi/linux#5929 kernel: drm: rp1: VEC and DPI drivers: Fix bug #5901 See: raspberrypi/linux#5925 kernel: drivers: media: cfe: Increase default size of embedded buffer See: raspberrypi/linux#5923 kernel: RP1 VEC: Use tv_mode from command line, align enum with drm_connector; tidy See: raspberrypi/linux#5885 kernel: ARM: dts: Standardise downstream Pi GPIO pin names See: raspberrypi/linux#5902 kernel: ASoC: DACplusADCPro - fix 16bit sample support in clock consumer mode See: raspberrypi/linux#5919 kernel: ASoC: adds support for Hifiberry AMP4Pro to the dacplus driver See: raspberrypi/linux#5918 kernel: ASoC: DACplus - fix 16bit sample support in clock consumer mode See: raspberrypi/linux#5917
popcornmix
added a commit
to raspberrypi/rpi-firmware
that referenced
this pull request
Feb 7, 2024
kernel: Improve I2C timing (again) See: raspberrypi/linux#5916 kernel: drm/vc4: Drop planes that have 0 destination size See: raspberrypi/linux#5929 kernel: drm: rp1: VEC and DPI drivers: Fix bug #5901 See: raspberrypi/linux#5925 kernel: drivers: media: cfe: Increase default size of embedded buffer See: raspberrypi/linux#5923 kernel: RP1 VEC: Use tv_mode from command line, align enum with drm_connector; tidy See: raspberrypi/linux#5885 kernel: ARM: dts: Standardise downstream Pi GPIO pin names See: raspberrypi/linux#5902 kernel: ASoC: DACplusADCPro - fix 16bit sample support in clock consumer mode See: raspberrypi/linux#5919 kernel: ASoC: adds support for Hifiberry AMP4Pro to the dacplus driver See: raspberrypi/linux#5918 kernel: ASoC: DACplus - fix 16bit sample support in clock consumer mode See: raspberrypi/linux#5917
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Feb 8, 2024
See: raspberrypi/linux#5923 kernel: overlays: Delete deprecated overlay mpu6050 kernel: overlays: Correct some compatible strings kernel: ASoC: DACplusADCPro - fix 16bit sample support in clock consumer mode See: raspberrypi/linux#5919 kernel: ASoC: adds support for Hifiberry AMP4Pro to the dacplus driver See: raspberrypi/linux#5918 kernel: ASoC: DACplus - fix 16bit sample support in clock consumer mode See: raspberrypi/linux#5917 kernel: Improve I2C timing (again) See: raspberrypi/linux#5916 kernel: Update PiTFT overlays for compatibility and consistency See: raspberrypi/linux#5903 kernel: Support non-standard I2C timings on Pi 5 See: raspberrypi/linux#5853 kernel: overlays: Add pcie-32bit-dma-pi5-overlay to enable 32bit DMA on the Pi 5's external PCIe interface See: raspberrypi/linux#5897 kernel: Improvement on backup-switchover-mode overlay value definitions See: raspberrypi/linux#5884 kernel: Pisound updates for Pi 5 See: raspberrypi/linux#5872
popcornmix
added a commit
to raspberrypi/rpi-firmware
that referenced
this pull request
Feb 8, 2024
See: raspberrypi/linux#5923 kernel: overlays: Delete deprecated overlay mpu6050 kernel: overlays: Correct some compatible strings kernel: ASoC: DACplusADCPro - fix 16bit sample support in clock consumer mode See: raspberrypi/linux#5919 kernel: ASoC: adds support for Hifiberry AMP4Pro to the dacplus driver See: raspberrypi/linux#5918 kernel: ASoC: DACplus - fix 16bit sample support in clock consumer mode See: raspberrypi/linux#5917 kernel: Improve I2C timing (again) See: raspberrypi/linux#5916 kernel: Update PiTFT overlays for compatibility and consistency See: raspberrypi/linux#5903 kernel: Support non-standard I2C timings on Pi 5 See: raspberrypi/linux#5853 kernel: overlays: Add pcie-32bit-dma-pi5-overlay to enable 32bit DMA on the Pi 5's external PCIe interface See: raspberrypi/linux#5897 kernel: Improvement on backup-switchover-mode overlay value definitions See: raspberrypi/linux#5884 kernel: Pisound updates for Pi 5 See: raspberrypi/linux#5872
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The former code did not adjust the physical sample width when in clock consumer mode and has taken the fixed 32 bit default. This has caused the audio to be played at half its frequency due to the fixed bclk_ratio of 64.
Problem appears only on PI5 as on the former PIs the I2S module did simply run at fixed 64x rate.