add rtw88/rtw89 drivers

[macmpi]

as per #6874

[pelwell]

What about the 64-bit defconfigs?

[macmpi]

What about the 64-bit defconfigs?

oops, missed 2712 (in fact did 2711 instead): any other to add?

[pelwell]

I'm only seeing the 32-bit ARCH=arm bcm2711_defconfig. The full list for...

Yes, like that.

[pelwell]

Hmmm - this isn't correct. Firstly, these are not true defconfig files, created with make ... savedefconfig. A defconfig file should only contain non-default, non-implied settings. Secondly, it seems that only the PCI-capable platforms actually gained anything - it's as if the USB devices were already enabled.

Running savedefconfig for each of those proposed changes has one of two results. On the four PCI-capable kernels, the changes look like this:

@@ -624,10 +624,21 @@ CONFIG_RTL8187=m
 CONFIG_RTL8192CU=m
 CONFIG_RTL8XXXU=m
 CONFIG_RTW88=m
+CONFIG_RTW88_8822BE=m
 CONFIG_RTW88_8822BU=m
+CONFIG_RTW88_8822CE=m
 CONFIG_RTW88_8822CU=m
+CONFIG_RTW88_8723DE=m
 CONFIG_RTW88_8723DU=m
+CONFIG_RTW88_8821CE=m
 CONFIG_RTW88_8821CU=m
+CONFIG_RTW89=m
+CONFIG_RTW89_8851BE=m
+CONFIG_RTW89_8852AE=m
+CONFIG_RTW89_8852BE=m
+CONFIG_RTW89_8852BTE=m
+CONFIG_RTW89_8852CE=m
+CONFIG_RTW89_8922AE=m
 CONFIG_ZD1211RW=m
 CONFIG_MAC80211_HWSIM=m
 CONFIG_IEEE802154_AT86RF230=m

i.e. the same 11 additions.

On the non-PCI kernels, the "changes" evaporate - those settings are already implied by the defconfig. For example, compare your bcmrpi_defconfig patch:

@@ -596,10 +596,38 @@ CONFIG_RTL8187=m
 CONFIG_RTL8192CU=m
 CONFIG_RTL8XXXU=m
 CONFIG_RTW88=m
+CONFIG_RTW88_CORE=m
+# CONFIG_RTW88_PCI is not set
+# CONFIG_RTW88_SDIO is not set
+CONFIG_RTW88_USB=m
+CONFIG_RTW88_8822B=m
+CONFIG_RTW88_8822C=m
+CONFIG_RTW88_8723X=m
+# CONFIG_RTW88_8703B is not set
+CONFIG_RTW88_8723D=m
+CONFIG_RTW88_8821C=m
+CONFIG_RTW88_8821A=m
+CONFIG_RTW88_8812A=m
+CONFIG_RTW88_8814A=m
+# CONFIG_RTW88_8822BE is not set
+# CONFIG_RTW88_8822BS is not set
 CONFIG_RTW88_8822BU=m
+# CONFIG_RTW88_8822CE is not set
+# CONFIG_RTW88_8822CS is not set
 CONFIG_RTW88_8822CU=m
+# CONFIG_RTW88_8723DE is not set
+# CONFIG_RTW88_8723DS is not set
+# CONFIG_RTW88_8723CS is not set
 CONFIG_RTW88_8723DU=m
+# CONFIG_RTW88_8821CE is not set
+# CONFIG_RTW88_8821CS is not set
 CONFIG_RTW88_8821CU=m
+CONFIG_RTW88_8821AU=m
+CONFIG_RTW88_8812AU=m
+CONFIG_RTW88_8814AU=m
+# CONFIG_RTW88_DEBUG is not set
+# CONFIG_RTW88_DEBUGFS is not set
+# CONFIG_RTW88_LEDS is not set
 CONFIG_ZD1211RW=m
 CONFIG_MAC80211_HWSIM=m
 CONFIG_IEEE802154_AT86RF230=m

with what already appears in the .config file after applying the existing bcmrpi_defconfig:

$ make ARCH=arm bcmrpi_defconfig
#
# configuration written to .config
#
$ grep RTW88_ .config
CONFIG_RTW88_CORE=m
CONFIG_RTW88_USB=m
CONFIG_RTW88_8822B=m
CONFIG_RTW88_8822C=m
CONFIG_RTW88_8723X=m
CONFIG_RTW88_8723D=m
CONFIG_RTW88_8821C=m
# CONFIG_RTW88_8822BS is not set
CONFIG_RTW88_8822BU=m
# CONFIG_RTW88_8822CS is not set
CONFIG_RTW88_8822CU=m
# CONFIG_RTW88_8723DS is not set
# CONFIG_RTW88_8723CS is not set
CONFIG_RTW88_8723DU=m
# CONFIG_RTW88_8821CS is not set
CONFIG_RTW88_8821CU=m
# CONFIG_RTW88_DEBUG is not set
# CONFIG_RTW88_DEBUGFS is not set

If you are in agreement, I'll replace this PR with a squashed version of the PCI defconfig changes for you to look at, before merging it.

[macmpi]

Yes thanks.
Just curious why on RT88 USB side, 8821AU, 8812AU, 8814AU do not get added as per Kconfig.

[pelwell]

Because they don't exist in 6.12: https://github.com/raspberrypi/linux/blob/rpi-6.12.y/drivers/net/wireless/realtek/rtw88/Kconfig

[pelwell]

This is what we've ended up with: https://github.com/raspberrypi/linux/pull/6881/files

[macmpi]

Ok thanks a lot.
(reminder for next pi kernel releases: 8821AU, 8812AU from 6.13 and 8814AU from 6.15)

[pelwell]

Enhanced versions of this patch have now been merged to 6.14 and 6.15 - 6.13 is EOL and will receive no further updates.

[macmpi]

Thanks for your help and patience.

PS: for 6.14 & 6.15 arm defconfigs could inherit newer USB too (not just arm64)