Don't delete jruby.sh #2517
Don't delete jruby.sh #2517
Conversation
I'm not sure why this file was being deleted but this code dates way back! Unfortunately deleting this interferes with a new version of the native JRuby launcher we want to release which is dependent on the shell script being present. This PR removes jruby.sh from the `remove_windows_files` function so it can be used by the new launcher. See jruby/jruby-launcher#48 (comment)
|
I gave this a try with |
|
This should also not interfere with the installation of the "classic" native launcher, since that overwrites the |
|
Thank you! |
|
@mislav Can you explain how this fix gets out to users? What process do they need to follow in e.g. rbenv? We are trying to decide if we have to hack the jruby-launcher gem to bring its own jruby.sh to work around the deletion on older ruby-build. |
The new skinny launcher depends on jruby.sh being in the same bin dir, but at least one installer (ruby-build) deletes it during initial setup. This patch includes jruby.sh in the gem and copies it into JRuby's bin dir if it does not already exist. See rbenv/ruby-build#2517
The new skinny launcher depends on jruby.sh being in the same bin dir, but at least one installer (ruby-build) deletes it during initial setup. This patch includes jruby.sh in the gem and copies it into JRuby's bin dir if it does not already exist. See rbenv/ruby-build#2517
|
@headius Certainly! Your fix is part of the latest ruby-build release: https://github.com/rbenv/ruby-build/releases/tag/v20250409 People will only benefit from this fix if they upgrade their ruby-build version prior to installing a new jruby version. Upgrading is done independently of rbenv: https://github.com/rbenv/ruby-build/wiki#updating-ruby-build If jruby releases currently included in ruby-build (prior to this fix) are vulnerable to |
|
Thank you for the clarification and for the release!
We ended up at the same conclusion, and the just-released jruby-launcher 2.0 will copy the latest jruby.sh into bin if it is not already present. I believe it should install and work properly for all rbenv installs prior to the change in this PR. |
No kidding. First PR to ruby-build ever! #1 |
I'm not sure why this file was being deleted but this code dates way back! Unfortunately deleting this interferes with a new version of the native JRuby launcher we want to release which is dependent on the shell script being present. This PR removes jruby.sh from the
remove_windows_filesfunction so it can be used by the new launcher.See jruby/jruby-launcher#48 (comment)