-
-
Notifications
You must be signed in to change notification settings - Fork 276
Refactor dumi #220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor dumi #220
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/react-component/field-form/ggs5tqhjg |
Codecov Report
@@ Coverage Diff @@
## master #220 +/- ##
=======================================
Coverage 99.89% 99.89%
=======================================
Files 13 13
Lines 937 937
Branches 203 203
=======================================
Hits 936 936
Misses 1 1 Continue to review full report at Codecov.
|
Nice work!thx~~ |
RC 目前看起来没有手写 doc 的需要,可以先使用 dumi 的 examples 模式(没写入文档),会自动识别 examples 目录下的 |
看起来很多 diff 是 code style,莫非 prettier or fabric 更新了规则 |
|
这是因为 |
@crazyair is attempting to deploy a commit to the React Component Team on Vercel. A member of the Team first needs to authorize it. |
@crazyair 确实有问题,晚点我发个版修复下 |
@PeachScript 👌 的话就合了哈~ |
In `rc-form`, we hope to help user auto trigger change event by setting to make redux dispatch easier, but it's not good design since it makes code logic couping. | ||
|
||
Additionally, user control update trigger `onFieldsChange` & `onValuesChange` event has potential dead loop risk. | ||
docs/index.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Emm, 这个删的有点多啊
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
可以做个连接 过去
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
嗯, @PeachScript 会支持一下
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
啊,好烦呀,家里 window 搞不了。。。Mac 可以敲命令,我明天试试
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
懂了,#222
试了下之前搞的 dumi 的 example 模式有点鸡肋,体验还是目前的 PR 好,就保持现状了 |
有一个问题,就是打包后,在 npm 里看不到 README ,因为根目录的 README 是一个软链接。还是需要在根目录里有实际的 README。 |
README.md 按理说应该是在 packages/dumi/README.md 目录下,后面优化的时候把 api 写到别处就好了。 |
我觉得我们两个说的不是一个问题。根目录 没有 README 导致 https://www.npmjs.com/package/rc-field-form 这里没有 |
#219