Skip to content

Refactor dumi #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Nov 16, 2020
Merged

Refactor dumi #220

merged 12 commits into from
Nov 16, 2020

Conversation

crazyair
Copy link
Contributor

@vercel
Copy link

vercel bot commented Nov 16, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/field-form/ggs5tqhjg
✅ Preview: https://field-form-git-refactor-dumi.react-component.vercel.app

@codecov
Copy link

codecov bot commented Nov 16, 2020

Codecov Report

Merging #220 (a36ec08) into master (8fe0a2b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #220   +/-   ##
=======================================
  Coverage   99.89%   99.89%           
=======================================
  Files          13       13           
  Lines         937      937           
  Branches      203      203           
=======================================
  Hits          936      936           
  Misses          1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fe0a2b...a36ec08. Read the comment docs.

@zombieJ
Copy link
Member

zombieJ commented Nov 16, 2020

Nice work!thx~~

@PeachScript
Copy link
Collaborator

RC 目前看起来没有手写 doc 的需要,可以先使用 dumi 的 examples 模式(没写入文档),会自动识别 examples 目录下的 j|tsx 生成单独的文档路由,可参考这个 PR:react-component/select#488

@PeachScript
Copy link
Collaborator

看起来很多 diff 是 code style,莫非 prettier or fabric 更新了规则

@crazyair
Copy link
Contributor Author

RC 目前看起来没有手写 doc 的需要,可以先使用 dumi 的 examples 模式(没写入文档),会自动识别 examples 目录下的 j|tsx 生成单独的文档路由,可参考这个 PR:react-component/select#488

image
examples 文件放根目录,这里会报错

@PeachScript
Copy link
Collaborator

examples 文件放根目录,这里会报错

这是因为 docs 被加进 eslintignore 了吧,要么为 examples 目录禁用 import/no-extraneous-dependencies 规则?

@crazyair
Copy link
Contributor Author

examples 文件放根目录,这里会报错

这是因为 docs 被加进 eslintignore 了吧,要么为 examples 目录禁用 import/no-extraneous-dependencies 规则?

image

@vercel
Copy link

vercel bot commented Nov 16, 2020

@crazyair is attempting to deploy a commit to the React Component Team on Vercel.

A member of the Team first needs to authorize it.

@PeachScript
Copy link
Collaborator

@crazyair 确实有问题,晚点我发个版修复下

@zombieJ
Copy link
Member

zombieJ commented Nov 16, 2020

@PeachScript 👌 的话就合了哈~

@zombieJ zombieJ merged commit 63c8a4c into react-component:master Nov 16, 2020
In `rc-form`, we hope to help user auto trigger change event by setting to make redux dispatch easier, but it's not good design since it makes code logic couping.

Additionally, user control update trigger `onFieldsChange` & `onValuesChange` event has potential dead loop risk.
docs/index.md
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Emm, 这个删的有点多啊

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以做个连接 过去

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

嗯, @PeachScript 会支持一下

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

啊,好烦呀,家里 window 搞不了。。。Mac 可以敲命令,我明天试试

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

懂了,#222

@PeachScript
Copy link
Collaborator

试了下之前搞的 dumi 的 example 模式有点鸡肋,体验还是目前的 PR 好,就保持现状了

@xrkffgg
Copy link
Member

xrkffgg commented Dec 5, 2020

有一个问题,就是打包后,在 npm 里看不到 README ,因为根目录的 README 是一个软链接。还是需要在根目录里有实际的 README。

@crazyair
Copy link
Contributor Author

crazyair commented Dec 5, 2020

有一个问题,就是打包后,在 npm 里看不到 README ,因为根目录的 README 是一个软链接。还是需要在根目录里有实际的 README。

README.md 按理说应该是在 packages/dumi/README.md 目录下,后面优化的时候把 api 写到别处就好了。

@xrkffgg
Copy link
Member

xrkffgg commented Dec 5, 2020

我觉得我们两个说的不是一个问题。根目录 没有 README 导致 https://www.npmjs.com/package/rc-field-form 这里没有

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants