Dayjs should parse date in strict mode #347
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix react-component#346 To avoid the input text to be parsed to early, parse text in strict mode.
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/react-component/picker/ECcHMcPM1fCbHmBH9WNHwbnMftgH |
|
thank you for fix 👍 |
iamkun
reviewed
Oct 17, 2022
| @@ -115,7 +115,7 @@ const generateConfig: GenerateConfig<Dayjs> = { | |||
| parseNoMatchNotice(); | |||
| return null; | |||
| } | |||
| const date = dayjs(formatText, format).locale(localeStr); | |||
| const date = dayjs(formatText, format, null, true).locale(localeStr); | |||
There was a problem hiding this comment.
https://day.js.org/docs/en/parse/string-format
seems dayjs(formatText, format, true) is better here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #346
To avoid the input text to be parsed to early, parse text in strict mode.