Skip to content

fix: change react deps to right spread #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 1, 2019
Merged

fix: change react deps to right spread #198

merged 1 commit into from
Nov 1, 2019

Conversation

frolovdev
Copy link
Contributor

"*" version is wrong peer dependency for react library and a bad tone (for example some tools like microsoft rush gives Error about using peer dependencies like this)

@vercel
Copy link

vercel bot commented Oct 31, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/react-component/tooltip/l8sxyxwvd
🌍 Preview: https://tooltip-git-fork-whispers12-fix-dependencies.react-component.now.sh

@frolovdev
Copy link
Contributor Author

@zombieJ

@codecov
Copy link

codecov bot commented Oct 31, 2019

Codecov Report

Merging #198 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #198   +/-   ##
=====================================
  Coverage      88%    88%           
=====================================
  Files           3      3           
  Lines          25     25           
  Branches       10     10           
=====================================
  Hits           22     22           
  Misses          3      3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc8cf77...33577c6. Read the comment docs.

@zombieJ zombieJ merged commit c4f9e9c into react-component:master Nov 1, 2019
@zombieJ
Copy link
Member

zombieJ commented Nov 1, 2019

+ [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants