Skip to content

feat: support to config overlay inner style #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 21, 2020

Conversation

AshoneA
Copy link
Contributor

@AshoneA AshoneA commented Apr 19, 2020

ref: ant-design/ant-design#23155

要做自定义得支持下 style

@vercel
Copy link

vercel bot commented Apr 19, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/tooltip/9v4h32f47
✅ Preview: https://tooltip-git-fork-ashonea-feat-overlay-inner-style.react-component.now.sh

@codecov
Copy link

codecov bot commented Apr 19, 2020

Codecov Report

Merging #213 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #213   +/-   ##
=======================================
  Coverage   88.00%   88.00%           
=======================================
  Files           3        3           
  Lines          25       25           
  Branches       10       10           
=======================================
  Hits           22       22           
  Misses          3        3           
Impacted Files Coverage Δ
src/Tooltip.tsx 83.33% <ø> (ø)
src/Content.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 185c031...e0cb98b. Read the comment docs.

@AshoneA
Copy link
Contributor Author

AshoneA commented Apr 19, 2020

@afc163 @zombieJ 帮忙看下合下

@zombieJ
Copy link
Member

zombieJ commented Apr 20, 2020

这个名字有点蛋疼,和 overlayStyle 挺像。似乎也省不掉。到 antd 里记得把它 omit 掉,免得别人用了。

@zombieJ
Copy link
Member

zombieJ commented Apr 20, 2020

另外,加个 test case 和备注,连到 antd issue 里。

@AshoneA
Copy link
Contributor Author

AshoneA commented Apr 20, 2020

这个名字有点蛋疼

三大难问题之命名难

加个 test case 和备注,连到 antd issue 里。

OK

@AshoneA
Copy link
Contributor Author

AshoneA commented Apr 28, 2020

@zombieJ check it!

@zombieJ zombieJ merged commit 25d6b06 into react-component:master May 21, 2020
@zombieJ
Copy link
Member

zombieJ commented May 21, 2020

+ [email protected]

shc023 pushed a commit to shc023/tooltip that referenced this pull request Jul 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants