-
Notifications
You must be signed in to change notification settings - Fork 107
translated warnings/dont-call-proptypes #121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
translated warnings/dont-call-proptypes #121
Conversation
Deploy preview for ar-reactjs ready! Built with commit 46bc192 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const message = `"${propName}" property of "${componentName}" has been deprecated.\n${explanation}`;
Co-Authored-By: Fortas Abdeldjalil <[email protected]>
Co-Authored-By: Fortas Abdeldjalil <[email protected]>
Co-Authored-By: Fortas Abdeldjalil <[email protected]>
شكرًا! |
That makes sense, sorry I was mistaken in that point.
That's true and it will be super weird if we reorder words so it will be understandable to the reader. We should find a solution for such cases |
I don't think it's that necessary to translate them, I saw the RTL setup, I think the code would look a bit odd if it's written RTL |
Co-Authored-By: Fortas Abdeldjalil <[email protected]>
Hi @Fcmam5, please review this PR and merge it after approving it.
Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mohshbool, I'm sorry I missed some "micro-mistakes", would you mind reviewing them?
Co-Authored-By: Fortas Abdeldjalil <[email protected]>
Co-Authored-By: Fortas Abdeldjalil <[email protected]>
Co-Authored-By: Fortas Abdeldjalil <[email protected]>
@Fcmam5 I have committed your suggestions, idk how I managed to miss them 😅 |
I haven't translated the
title
because I wasn't sure whether to do so or not since some of the translations did and some others didn't!