Skip to content

translated warnings/invalid-aria-prop #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 2, 2019
Merged

translated warnings/invalid-aria-prop #123

merged 3 commits into from
Jul 2, 2019

Conversation

mohshbool
Copy link
Member

done translating warnings/invalid-aria-prop.*

mohshbool
mohshbool commented Jun 29, 2019
View reviewed changes
@netlify
Copy link

netlify bot commented Jun 29, 2019 •
edited
Loading

Deploy preview for ar-reactjs ready!

Built with commit 175aa2e

https://deploy-preview-123--ar-reactjs.netlify.com

@tesseralis tesseralis mentioned this pull request Jun 29, 2019
Closed
Fcmam5
Fcmam5 reviewed Jul 1, 2019
View reviewed changes
Copy link
Collaborator

@Fcmam5 Fcmam5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All my respect Mohammed! I really love what you're doing, especially when it comes to "make tashkeel" to the hard words.
I had some micro-suggestions 🔬 to fix when it's possible :)

@mohshbool @Fcmam5
remove unnecessary space
3fc4e93 
Co-Authored-By: Fortas Abdeldjalil <[email protected]>
@iRayan7
Copy link
Member

iRayan7 commented Jul 2, 2019

Hi @Fcmam5, please review this PR and merge it after approving it.
make sure you checked out this note from #1

Warnings
These are the pages that you get when you click the links in the console (e.g. https://reactjs.org/warnings/dont-call-proptypes.html). People tend to search these, so please don't translate the error message itself.

Thanks.

mohshbool
mohshbool commented Jul 2, 2019
View reviewed changes
@mohshbool
Copy link
Member Author

@Fcmam5 I think it's done now 😄

@Fcmam5 Fcmam5 merged commit 83b25d9 into reactjs:master Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fcmam5 Fcmam5 Fcmam5 approved these changes

Assignees

@Fcmam5 Fcmam5

Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mohshbool @iRayan7 @Fcmam5