Skip to content

Fix heading level issue #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2023
Merged

Fix heading level issue #7

merged 1 commit into from
May 27, 2023

Conversation

mirorauhala
Copy link
Collaborator

The third heading level caused an error on JavaScript in JSX with curly braces.

TypeError: Cannot read properties of undefined (reading 'current') at src/components/MDX/Challenges/Navigation.tsx (68:44)

Changing to the fourth heading level fixes this. This PR also fixes the heading level for Importing and exporting components, where the heading level caused scroll jumps.

@github-actions
Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@mirorauhala mirorauhala merged commit ecb4f4b into main May 27, 2023
@mirorauhala mirorauhala deleted the rendering-bug branch May 27, 2023 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant