Support for create-react-class package

[wcjordan]

Fixes #176, adding support for the new create-react-class package.

I'm not familiar with recast (but have dabbled with estraverse), so any tips or suggestions are appreciated. Thanks!

[fkling]

I just restarted the CI build. I failed with a call stack size error, but I don't see why it would...

[wcjordan]

Weird. I'm able to reproduce locally though, so I can dig in.

[wcjordan]

I believe the issue is that this is very promiscuous

if (!match(path.node, {type: 'CallExpression'})) {
  return false;
}
var module = resolveToModule(path.get('callee', 'object'));

One heuristic I could take would be to assume the method will be named createReactClass e.g. import createReactClass from 'create-react-class'; or const createReactClass = require('create-react-class');.

Another alternative might be to make a lighter weight version of resolveToModule which doesn't follow MemberExpressions or VariableDeclarators e.g. assume we're importing directly into the variable as which we use createReactClass.

Thoughts? Also I'd like to write some tests for these cases. Would it be best to imitate something like isReactComponentClass-test.js?

[fkling]

Also I'd like to write some tests for these cases. Would it be best to imitate something like isReactComponentClass-test.js?

Yep, that's a good idea (I didn't realize there was no unit test for that module)! Adding a component to https://github.com/reactjs/react-docgen/tree/master/src/__tests__/fixtures for the snapshot test would also be good.

Thank you for working on this!

[fkling]

This might actually be the culprit. The value of callee for the CallExpression is Identifier, which doesn't have an object field: http://astexplorer.net/#/gist/2830b1b852ac298dab2f18802133afdf/ec06e05ba93e93903bb7c85a1bd6a12622d41918 .

I think you can do resolveToModule(path) here, that should solve the issue.

[wcjordan]

Your tip worked like a charm. Thanks!
Also I've added tests for existing and new functionality as well as a new snapshot.
I've also verified it works for fixed-data-table-2's usage.

I'm feeling much better about things now. Let me know if you have any additional suggestions.

[fkling]

Published as v2.15.0 and v3.0.0-beta4. Thank you!