Skip to content

Attempt to support system-components #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 7, 2018
Merged

Attempt to support system-components #292

merged 3 commits into from
Dec 7, 2018

Conversation

sapegin
Copy link
Contributor

@sapegin sapegin commented Aug 26, 2018

Support components created with factory functions, like system-components:

import system from 'system-components';
const Foo = system({
  is: 'button'
}, 'space');
Foo.propTypes = {};
export default Foo;

This partially fixes #239

Will also require changes in react-docgen-annotation-resolver.

sapegin and others added 3 commits August 26, 2018 12:23
This partially fixes #239

Will also require changes in react-docgen-annotation-resolver.
@danez danez added the bug label Dec 7, 2018
@danez danez merged commit fde44c1 into reactjs:master Dec 7, 2018
@okonet
Copy link

okonet commented Dec 8, 2018

That’s amazing! Thanks Artem!!!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does not recognize a CallExpression.
3 participants