-
Notifications
You must be signed in to change notification settings - Fork 321
Upgraded ArgoCD operator, ArgoCD to pick up the fix error when route api is not available (cherry-pick) #770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgraded ArgoCD operator, ArgoCD to pick up the fix error when route api is not available (cherry-pick) #770
Conversation
… not reachable Signed-off-by: Anand Francis Joseph <[email protected]>
cb7e7c2
to
ed96881
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/retest-required |
Signed-off-by: Anand Francis Joseph <[email protected]>
Signed-off-by: Anand Francis Joseph <[email protected]>
@anandf: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/retest |
/approve |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anandf, svghadi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4ccd3cb
into
redhat-developer:v1.13
What type of PR is this?
/kind bug
cherry pick of PR: #761
What does this PR do / why we need it:
When there is an issue with the API server pods, or the API server pods are just coming up after a restart, the current check for API availability done with a discovery client will fail. This makes the operator code to assume that the server does not support the Route API. To fix this, whenever the API availability check fails, the operator checks if the API is registered. If registered, then the operator assumes that the Route API is supported in the cluster and would eventually become available.
Have you updated the necessary documentation?
Which issue(s) this PR fixes:
Fixes https://issues.redhat.com/browse/GITOPS-4358
How to test changes / Special notes to the reviewer:
Steps to reproduce the problem in OCP cluster.
Delete the API server pods and restart the gitops-operator pod
Now try logging in to the ArgoCD UI, you will see an error like below