Skip to content

Upgraded ArgoCD operator, ArgoCD to pick up the fix error when route api is not available (cherry-pick) #770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 18, 2024

Conversation

anandf
Copy link
Member

@anandf anandf commented Aug 26, 2024

What type of PR is this?
/kind bug

cherry pick of PR: #761
What does this PR do / why we need it:
When there is an issue with the API server pods, or the API server pods are just coming up after a restart, the current check for API availability done with a discovery client will fail. This makes the operator code to assume that the server does not support the Route API. To fix this, whenever the API availability check fails, the operator checks if the API is registered. If registered, then the operator assumes that the Route API is supported in the cluster and would eventually become available.

Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:

Fixes https://issues.redhat.com/browse/GITOPS-4358

How to test changes / Special notes to the reviewer:

Steps to reproduce the problem in OCP cluster.

Delete the API server pods and restart the gitops-operator pod

oc delete pod --all --wait=false -n openshift-apiserver --all
oc delete pods --all -n openshift-gitops-operator

Now try logging in to the ArgoCD UI, you will see an error like below

oidc: issuer did not match the issuer returned by provider, expected "https://openshift-gitops-server-openshift-gitops.apps.<DNS_DOMAIN_NAME>/api/dex" got "https://openshift-gitops-server/api/dex"

@anandf anandf changed the base branch from master to v1.13 August 26, 2024 12:06
@anandf anandf changed the title Check API registration if API is not available (cherry-pick) Upgraded ArgoCD operator, ArgoCD to pick up the fix error when route api is not available (cherry-pick) Aug 26, 2024
Copy link
Member

@svghadi svghadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@anandf
Copy link
Member Author

anandf commented Sep 16, 2024

/retest-required

@openshift-ci openshift-ci bot removed the lgtm label Sep 17, 2024
Copy link

openshift-ci bot commented Sep 17, 2024

@anandf: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v4.12-kuttl-sequential cb7e7c2 link true /test v4.12-kuttl-sequential
ci/prow/v4.13-ci-index-gitops-operator-bundle cb7e7c2 link true /test v4.13-ci-index-gitops-operator-bundle
ci/prow/v4.12-images cb7e7c2 link true /test v4.12-images
ci/prow/v4.12-e2e cb7e7c2 link true /test v4.12-e2e
ci/prow/v4.12-ci-index-gitops-operator-bundle cb7e7c2 link true /test v4.12-ci-index-gitops-operator-bundle
ci/prow/v4.13-e2e cb7e7c2 link true /test v4.13-e2e
ci/prow/v4.12-kuttl-parallel cb7e7c2 link true /test v4.12-kuttl-parallel
ci/prow/v4.13-images cb7e7c2 link true /test v4.13-images
ci/prow/v4.13-kuttl-parallel cb7e7c2 link true /test v4.13-kuttl-parallel
ci/prow/v4.13-kuttl-sequential cb7e7c2 link true /test v4.13-kuttl-sequential

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@anandf
Copy link
Member Author

anandf commented Sep 18, 2024

/retest

@svghadi
Copy link
Member

svghadi commented Sep 18, 2024

/approve

@svghadi
Copy link
Member

svghadi commented Sep 18, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 18, 2024
@anandf
Copy link
Member Author

anandf commented Sep 18, 2024

/approve

Copy link

openshift-ci bot commented Sep 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anandf, svghadi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 4ccd3cb into redhat-developer:v1.13 Sep 18, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants