Skip to content

Move web-app to root dir #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 28, 2023
Merged

Move web-app to root dir #6

merged 1 commit into from
Mar 28, 2023

Conversation

F-X64
Copy link
Member

@F-X64 F-X64 commented Mar 21, 2023

No description provided.

@F-X64 F-X64 requested review from major and miyunari March 21, 2023 06:37
major
major requested changes Mar 21, 2023
View reviewed changes
Copy link
Member

@major major left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like where you're going here, but I'm worried about the --delete-removed part here. That would delete the other content in the bucket (like the image data) unless I am missing something.

@F-X64
Copy link
Member Author

F-X64 commented Mar 28, 2023

I like where you're going here, but I'm worried about the --delete-removed part here. That would delete the other content in the bucket (like the image data) unless I am missing something.

Good catch! Yeah I'd say that doesn't make much sense anymore if we move away from the web-app subfolder

@F-X64 F-X64 force-pushed the move-staticpage-to-root branch from 7631bfa to 884826e Compare March 28, 2023 10:01
@F-X64 F-X64 requested a review from major March 28, 2023 10:01
@major major merged commit ca758ab into main Mar 28, 2023
@major major deleted the move-staticpage-to-root branch March 28, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@major major major approved these changes

@miyunari miyunari Awaiting requested review from miyunari

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@F-X64 @major