Skip to content

fix(webpack): duplicate build assets #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

schogges
Copy link
Contributor

@schogges schogges commented Apr 5, 2023

With webpack v5 Asset Modules got introduced and which run by default. So basically the different loaders and asset modules loaded the assets and emitted to the dist-folder.

Solves #60

Copy link
Member

@miyunari miyunari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for your contribution @schogges ! 🥳 😄

@miyunari miyunari merged commit 64cc384 into redhatcloudx:main Apr 6, 2023
@F-X64
Copy link
Member

F-X64 commented Apr 6, 2023

Amazing, thanks for fixing this!

@schogges
Copy link
Contributor Author

schogges commented Apr 6, 2023

It was my pleasure 🙂

@schogges schogges deleted the fix/webpack/duplicate_build_assets branch April 6, 2023 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants